OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
690 stars 95 forks source link

Excel Function Arguments popup displaying #value for string parameter with custom function #4853

Open vivek-insight opened 2 months ago

vivek-insight commented 2 months ago

We have created custom functions for excel. When we add a new function using the Excel Function Arguments window (fx) it works fine. But after saving the sheet and opening the sheet again, after that when we open function arguments for the same formula then #value is displayed for all string parameters, and all other parameters displays number as there type. Same issue also occurs if we copy formula from one sheet to another and open it in second sheet. I am currently using manifest file reference from shared folder.

Your Environment

Expected behavior

The Excel Function Arguments window should correctly show the values for each parameter.

Current behavior

After saving when we again open the excel and select the formula, the value of string parameters are shown as #value in the Excel Function Arguments window

Steps to reproduce

  1. Create and build the yo office custom function with reactjs.
  2. Load the manifest using the instructions to Sideload Office Add-ins for testing from a network share.
  3. Open the excel function arguments windows and add newly created formula.
  4. Save the excel and open the excel again
  5. After opening the excel again click the already added formula and open function arguments window now you can see string parameter displaying #value
  6. you can also try copying of formula from one sheet to another and open formula on second sheet same issue occurs

Context

Users will be confused and consider this an error with the Add-in custom function

Before Save before_Save

After save / or copy paste After_Save

shanshanzheng-dev commented 2 months ago

Hi @vivek-insight Thanks for reporting this issue. We'll take a look and report back if we have a suggestion for you.

vivek-insight commented 2 months ago

@shanshanzheng-dev Hi did you find any solution ?

shanshanzheng-dev commented 2 months ago

Hi @vivek-insight Sorry for slow response. This is a our new feature. All codes are checked in. We will update for you once the feature is fully release to production. It's around several weeks after.

vivek-insight commented 1 month ago

@shanshanzheng-dev any tentative date when we can expect this feature.

qinliuMSFT commented 1 month ago

Hi @vivek-insight, the feature should be available on the current monthly channel (Version 2409 Build 18025.xxxxx and later) on Win32 platform. Please let me know if you are able to use it.

vivek-insight commented 1 month ago

@qinliuMSFT issue is still replicable. currently using Microsoft® Excel® for Microsoft 365 MSO (Version 2409 Build 16.0.18025.20160) 64-bit excel version. Any tentative date when we can expect the same in 64 bit platform