search

OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
689 stars 95 forks source link

Add-in manifests fail to validate when they contain AppDomains tag #5057

Closed nivgoldsteiniron closed 1 week ago

nivgoldsteiniron commented 2 weeks ago

Provide required information needed to triage your issue

Manifest XML fails validation after adding AppDomains.

This is a continuation of https://github.com/OfficeDev/office-js/issues/4858

I have added AppDomains as @neprasad-microsoft recommended, and it fixed the issue with the popups (in https://github.com/OfficeDev/office-js/issues/4858)

However, adding AppDomains caused the add-in verification to fail.

I did some trial and error and found that removing the tags IconUrl and HighResolutionIconUrl made it work, and I was able to install the add-in via the sideload menu https://aka.ms/olksideload

Since this workaround worked, that's why I closed the previous issue (This is a continuation of https://github.com/OfficeDev/office-js/issues/4858 )

However, this workaround failed validation when I tried uploading via Admin portal: https://admin.microsoft.com/Adminportal/Home#/Settings/IntegratedApps -> Upload Custom Apps -> App Type: Office Add-in -> Upload manifest file (.xml) from device.

addin.xml addin_without_icons.xml addin_without_appdomains.xml

Your Environment

Expected behavior

I expect addin.xml to not fail validation when uploading via Admin portal

Current behavior

When uploading via Admin portal, addin.xml and addin_without_icons.xml fails to validate but addin_without_appdomains.xml validates successfully. When uploading via sideload, addin.xml fails to validate but addin_without_icons.xml and addin_without_appdomains.xml validates successfully.

Steps to reproduce

Go to https://admin.microsoft.com/Adminportal/Home#/Settings/IntegratedApps as an admin account Then click: Upload Custom Apps -> App Type: Office Add-in -> Upload manifest file (.xml) from device.

To try out the sideload: open sideload https://aka.ms/olksideload On the left sidebar My add-ins->Custom addins->Add a custom add-in->Add from File...

anjalitp commented 1 week ago

It seems the elements are not following the expected order which is causing Add-in manifest validation to fail. Please update the manifest to have the AppDomain element after the icon urls. Attaching the updated manifest here which seems to be working. addin.xml.txt

To learn more about the ordering of elements please refer this doc https://learn.microsoft.com/en-us/office/dev/add-ins/develop/manifest-element-ordering

nivgoldsteiniron commented 1 week ago

It works, Thanks so much @anjalitp !