search

OfficeDev / office-ui-fabric-core

The front-end CSS framework for building experiences for Office and Microsoft 365.
https://developer.microsoft.com/en-us/fabric
Other
3.77k stars 467 forks source link

How to onboard missing Fabric icons to the library? #1189

Open traceysaur opened 5 years ago

traceysaur commented 5 years ago

Looks like there is only a dashboard_add icon for Power BI. How do we onboard other missing icons. i.e. dashboard icon to the left is missing Screen Shot 2019-08-15 at 10 07 02 AM

Jahnp commented 5 years ago

Hi @traceysaur , there is a process for adding new icons to the Fabric font. I know that internally, these icons have already been added to the base font, so there is now work I need to do to add it to Fabric. However, before my team begins that work, would this be for Fabric Core (this repo) or Fabric React? I assume your team is using Fabric React, but wanted to verify as the updating process is different.

traceysaur commented 5 years ago

Hi Peter,

Our team is using Fabric React. Thanks for checking. Although-- I think Matthew Ropel is working on this (see attached). Can you confirm?

Thanks, Tracey

From: Peter Jahn notifications@github.com Reply-To: OfficeDev/office-ui-fabric-core reply@reply.github.com Date: Monday, August 19, 2019 at 3:55 PM To: OfficeDev/office-ui-fabric-core office-ui-fabric-core@noreply.github.com Cc: Tracey Saur trng@microsoft.com, Mention mention@noreply.github.com Subject: Re: [OfficeDev/office-ui-fabric-core] How to onboard missing Fabric icons to the library? (#1189)

Hi @traceysaurhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftraceysaur&data=02%7C01%7Ctrng%40microsoft.com%7Cbbf47050c3b845b73f7408d724f85a51%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637018521423081849&sdata=Q2pTLGT%2Fb3PczCDG9Wp%2FQdm2eYXLazXJeuzvW1jgkxM%3D&reserved=0 , there is a process for adding new icons to the Fabric font. I know that internally, these icons have already been added to the base font, so there is now work I need to do to add it to Fabric. However, before my team begins that work, would this be for Fabric Core (this repo) or Fabric React? I assume your team is using Fabric React, but wanted to verify as the updating process is different.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Foffice-ui-fabric-core%2Fissues%2F1189%3Femail_source%3Dnotifications%26email_token%3DAM5EOD4OSEHAE2E5KDHJ6VLQFMQGTA5CNFSM4IMAFQN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UQ7NQ%23issuecomment-522784694&data=02%7C01%7Ctrng%40microsoft.com%7Cbbf47050c3b845b73f7408d724f85a51%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637018521423081849&sdata=ZYcFbwF7LpQPMWgbDi0INdBNeZCOrJR0ktxew8ddb0o%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM5EOD3U4OLCXIZQWBEZDYLQFMQGTANCNFSM4IMAFQNQ&data=02%7C01%7Ctrng%40microsoft.com%7Cbbf47050c3b845b73f7408d724f85a51%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637018521423091845&sdata=2UJtupd8uxDgoOgHlAs6kj1gMBE9%2FqtJ23qlTH%2FGVX0%3D&reserved=0.