search

OfficeDev / office-ui-fabric-core

The front-end CSS framework for building experiences for Office and Microsoft 365.
https://developer.microsoft.com/en-us/fabric
Other
3.77k stars 466 forks source link

Fix incompatibility with Angular 8.x and up. #1216

Closed josteink closed 4 years ago

josteink commented 4 years ago

This closes https://github.com/OfficeDev/office-ui-fabric-core/issues/1192.

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

josteink commented 4 years ago

Not sure what the proper way to fix this is. Could someone please provide me some leads?

viceice commented 4 years ago

i think you need to move the required mixin to the docs sass file

josteink commented 4 years ago

@viceice : That did it. Thanks!

Build-errors fixed. Would be nice if someone could look into this issue now.

Not being able to work with a modern Angular-version is quite a show-stopper.

lindalu-MSFT commented 4 years ago

@josteink Thanks for your help! I don't monitor this repo regularly unless I get a security alert so please @lindalu-MSFT me if you need me to merge anything. Cheers!