OfficeDev / office-ui-fabric-core

The front-end CSS framework for building experiences for Office and Microsoft 365.
https://developer.microsoft.com/en-us/fabric
Other
3.78k stars 465 forks source link

Issue with ms-animation mixin with Sass (latest version of DartSass) #1275

Open valentintudor opened 3 years ago

valentintudor commented 3 years ago

There is an error with the ms-animation mixin from _Animation.Mixins.MDL2.scss which is also a deprecated file (imported in _Animation.Mixins.scss) and imported from _References.scss.

ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js): SassError: $string: ms-fadeIn is not a string.

177 │ $namelist: append($namelist, unquote($newname), 'comma');

Some people recommend to use the latest node-sass version, but this is deprecated, since the dart-sass implementation of Sass with Dart language is now preferred. This would not be an option.

Please fix this issue, you can't build a Webpack project from Fluent UI Sass sources because of this small issue. These are deprecated stuff which should be removed in a future version, but currently it's blocking and you are required to use the CSS directly. I know this is a well known issue lasting since last year, but currently not fixed.