Incremental translation of German strings for new English ones

[Zlatkovsky]

A running issue for needing incremental translations of strings into German, as we add new English ones.

Strings are under these two files:

• src\client\app\strings\german.ts
• \src\server\strings\german.ts

Search for use of the variable englishSubstitutesForNotYetTranslated, and you'll see the ones that are still needed.

When the strings are translated, feel free to close this issue, and we can just re-open it every time that there are new strings.

[Zlatkovsky]

Need translation of englishSubstitutesForNotYetTranslated.snippetInfoDialogTitle

[jakobpn]

Need translation of the Description string in the manifest:

<Description DefaultValue="Create, run, and share your Office Add-in code snippets from within Excel, Word, or PowerPoint." />

[jakobpn]

Need translation of "Run - Code - Share" tagline.

[jakobpn]

I created a pull request with the manifests that include the German strings: https://github.com/OfficeDev/script-lab/pull/475

[maninweb]

I have a question regarding the manifest files: if I understand it right, the strings are overridden only for Germany (de-de). But in Austria (de-at) and some swiss (de-ch) people are speaking German too. So, should be the de-de overrides in the manifest file be duplicated to de-at and de-ch? Or will the Add-In automatically recognize this by the first two letters "de"? (In the TypeScript files, it's not a problem, as the code considers only the first 2 letters de)

[Zlatkovsky]

@maninweb , a lovely question for you to put up on Stack Overflow, tagged with "office-js" :-) I don't know the answer offhand, but folks on my team should be monitoring it. If you don't get a response back, of if it's not a response you like, let me know... :-)

[maninweb]

Ok :-)

[maninweb]

I have updated the strings and created 2 pull requests. Note: my question about the country codes is here on StackOverflow. So, let's see what the team will recommend :-)

[Zlatkovsky]

Closing for now. We'll re-open this once we have new strings, and just keep on playing ping-pong with this issue.

[Zlatkovsky]

@maninweb , and as for the question on StackOverflow, Jakob has gone ahead and made the recommended change: https://github.com/OfficeDev/script-lab/commit/18f9d1bb0fb7482291dad962fbe06b7d7ea69d7b

[Zlatkovsky]

New string added, whenever you have the time:

https://github.com/OfficeDev/script-lab/pull/467/commits/3b2d3487084c04927590acaa703c63f3e6d23a64

[cshashwat]

Updated old strings and added some new ones, would appreciate a translation:

New: 'gistUpdateUrlIsSameAsBefore' 'gistUpdateSuccess' 'alpha' 'beta' 'production'

Updated: 'sharePublicSnippetConfirm' 'sharePrivateSnippetConfirm' 'aboutSwitchEnvironment'

Thanks.

https://github.com/OfficeDev/script-lab/pull/499/commits/884b8bb5d4d80b9ebad7a2172a8665576266d884

[Zlatkovsky]

Mourad, note that the new and updated strings are not checked in yet, but will be in a few hours

[maninweb]

Ok, something for me for tomorrow (my time).

[maninweb]

Hi, I have updated the strings and created a pull request :-)

[Zlatkovsky]

@cshashwat , please close once you merge in the pull request

[maninweb]

Hi there, I noticed that some new strings are included and I guess, this issue will be open again soon and then I will translate them. Before I translate them, can someone please explain me, what you mean with this string in English: viewModeGistUrlLabel: /** NEEDS STRING REVIEW */ 'Script-Lab view-only URL',

I found this string in the client part and I could not find out in which context it is used. Thank you :-)

Best, Mourad

[maninweb]

Hi there, I have another question: as the de attribute in the manifest does not work but the de-de attribute works (for me locally), should I replace de by de-de and eventually add de-at and de-ch as work around? What do you think?

Best, Mourad

[Zlatkovsky]

@maninweb , there are going to be a couple new strings soon, for Outlook (currently in pull request). That's why @annich-MS opened up this issue.

For the "Script-Lab view-only URL": don't worry about it. It's a temporary string that's going anyway.

For the manifest, we'll take care of it on our end. I filed a bug and assigned it to our PM, who will do this for all the languages (we now support Spanish and Chinese, as well). https://github.com/OfficeDev/script-lab/issues/560

[maninweb]

Hi there,

I just created a pull request for new translations and small improvements/corrections for exiting ones. I did not translate this one viewModeGistUrlLabel: /** NEEDS STRING REVIEW */ 'Script-Lab view-only URL',, as it's temporary.

Best, Mourad

[maninweb]

Hi there,

I created another pull request for a small change in the manifest files, based on feedback of friends and improving the wording.

Best, Mourad

[maninweb]

Hi there,

I am currently going to translate the new English strings into German. I've found the two strings for showExperimentationFlags and invalidExperimentationFlags. Am I right, if I guess that the experimentation flags are only for dev's? If so, should I then leave them as is in English?

Best, Mourad

[Zlatkovsky]

It's something that will show up in the "about" window, visible to all. So translating it is probably best

[maninweb]

Hi Michael, thanks, I have translated them and created a pull request some minutes ago. Best, Mourad

[maninweb]

Hi there, hope you are all well - a question: would it make sense for the current version to translate the new untranslated strings into German? Best, Mourad

[jakobpn]

Sounds worthwhile to me. Many thx for the contribution!

[maninweb]

Hi there, I did a pull request for an update of the translations.

While looking for new strings, I noticed, that src/client/app/views/custom-functions-soming-soon.html has a hard coded string at line 29 and src/client/app/views/custom-functions-dashboard.html has hard coded strings at line 49 and 67.

Will the strings from react/components/* be moved to the string files at a later time?

Best, Mourad