search

OfficeDev / script-lab

Create, run and share your code directly from Office
MIT License
702 stars 161 forks source link

Screen cut off (footer hidden) on both Editor and Runner on Excel Online #382

Open Zlatkovsky opened 5 years ago

Zlatkovsky commented 5 years ago

Reproed on localhost and Chrome. But presumably on others as well.

What makes this bad is that without the footer in the runner, can't twiddle Autoscroll (further exacerbating issue #380), and can't go to settings, either.

Not an absolutely blocker (at least, if you separately fix the autoscroll issue), but would ideally make it into 1.0.

nico-bellante commented 5 years ago

Any idea how to fix this? It doesn't repro when the site is loaded normally....

Zlatkovsky commented 5 years ago

@nico-bellante , one crude way might be to trigger a window re-layout after loading on the WAC (maybe at the same time as you dismiss the loading splash screen)?

Zlatkovsky commented 5 years ago

Or worst case, to do a special WAC padding on the bottom, kind of like we do for the icon in the top-right of the header. For purposes of V1 shipping, I'd rather err on the side of having a bit of extra whitespace rather than being cut off...

Zlatkovsky commented 5 years ago

@nico-bellante , adding it to your plate. Could you please take a look, and maybe just do a WAC padding on the bottom as a quick-and-dirty workaround? That seems better than having the WAC get the footer cut off, given that that's where the runner's console button is, and where the settings are in the editor.

Zlatkovsky commented 5 years ago

Repro seems to be:

  1. Open runner first.
  2. Then open editor
nico-bellante commented 5 years ago

image Above is evidence this is indeed a platform bug. (See taskpane div size)

Zlatkovsky commented 5 years ago

Redirecting to Petra. @peronald , could you work with the WAC add-in framework folks (Roger/Heidi, and probably Henry as the IC) to get this looked at and priorotized. We aren't the only ones who are being broken by this...

Zlatkovsky commented 5 years ago

Removing "stale" label. I just saw it again yesterday. @peronald , would be good to get the Platform to look into it.

Zlatkovsky commented 5 years ago

@peronald , I continue to see this happening occasionally. Has this been reported to the appropriate owners?

peronald commented 5 years ago

@Zlatkovsky Yes it has. I asked for an update. will get back when they do.