search

OfficeDev / teams-toolkit

Developer tools for building Teams apps
Other
453 stars 185 forks source link

perf: improve credential masker #12330

Closed jayzhang closed 3 weeks ago

jayzhang commented 3 weeks ago

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/29306214

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (e54770b) to head (aadc25b). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/fx-core/src/common/secretmasker/feature.ts 91.66% 2 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12330/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12330?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #12330 +/- ## ========================================== + Coverage 89.62% 89.63% +0.01% ========================================== Files 582 582 Lines 34432 34453 +21 Branches 6607 6655 +48 ========================================== + Hits 30858 30881 +23 Misses 1586 1586 + Partials 1988 1986 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12330?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [packages/fx-core/src/common/secretmasker/masker.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12330?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcommon%2Fsecretmasker%2Fmasker.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tbW9uL3NlY3JldG1hc2tlci9tYXNrZXIudHM=) | `95.23% <ø> (ø)` | | | [...ackages/fx-core/src/common/secretmasker/feature.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12330?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcommon%2Fsecretmasker%2Ffeature.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tbW9uL3NlY3JldG1hc2tlci9mZWF0dXJlLnRz) | `96.73% <91.66%> (+3.78%)` | :arrow_up: |