OfficeDev / teams-toolkit

Developer tools for building Teams apps
Other
453 stars 185 forks source link

chore: add logic for support single meta os taskpane create option #12359

Closed ZYUN-MSFT closed 2 weeks ago

ZYUN-MSFT commented 2 weeks ago

PM Spec Here

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (1fac52f) to head (5f809e3). Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...e/src/component/generator/officeAddin/generator.ts 83.33% 0 Missing and 1 partial :warning:
packages/fx-core/src/question/create.ts 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12359/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #12359 +/- ## ======================================= Coverage 89.63% 89.63% ======================================= Files 582 582 Lines 34469 34483 +14 Branches 6702 6619 -83 ======================================= + Hits 30897 30910 +13 Misses 1586 1586 - Partials 1986 1987 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [packages/fx-core/src/common/featureFlags.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12359?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcommon%2FfeatureFlags.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tbW9uL2ZlYXR1cmVGbGFncy50cw==) | `96.92% <100.00%> (+0.09%)` | :arrow_up: | | [packages/fx-core/src/question/constants.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12359?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fquestion%2Fconstants.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vY29uc3RhbnRzLnRz) | `96.04% <100.00%> (+0.05%)` | :arrow_up: | | [...e/src/component/generator/officeAddin/generator.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12359?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FofficeAddin%2Fgenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VBZGRpbi9nZW5lcmF0b3IudHM=) | `95.00% <83.33%> (-0.77%)` | :arrow_down: | | [packages/fx-core/src/question/create.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12359?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fquestion%2Fcreate.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vY3JlYXRlLnRz) | `91.69% <80.00%> (+0.05%)` | :arrow_up: |
ZYUN-MSFT commented 2 weeks ago

image

image

MuyangAmigo commented 2 weeks ago

image

image

So Task Pane can be used across WXPO now correct? Can you share the next screen if I select Task Pane?

hermanwenhe commented 2 weeks ago

image image

So Task Pane can be used across WXPO now correct? Can you share the next screen if I select Task Pane?

Yes. Our goal is to release task pane with WXPO support in next prerelease (assume it will be in Oct)

Next screen would be folder selection:

image

ZYUN-MSFT commented 2 weeks ago

image

image

This option will be avaliable for wxpo. And no programming lang need to be selected.

hermanwenhe commented 2 weeks ago

@tecton We will use a separate PR to clean these feature gates after WXP MOS public preview.

MuyangAmigo commented 2 weeks ago

Okay sounds good @ZYUN-MSFT @hermanwenhe Thanks!