OfficeDev / teams-toolkit

Developer tools for building Teams apps
Other
457 stars 188 forks source link

Teams Toolkit publish option does not work correctly #12518

Open say-brad opened 1 week ago

say-brad commented 1 week ago

Describe the bug We have created Azure Open AI Bot and published using the teams option which recommended using team tool kit and publishing the bot via teams do not provide any response.

To Reproduce Steps to reproduce the behavior: (please see attached word document for reproducing the error) [Create an Azure Bot in Azure Portal.docx] (https://github.com/user-attachments/files/17368494/Create.an.Azure.Bot.in.Azure.Portal.docx)

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior The bot receive messages and does not responds the message and also receive a 401 message.

Screenshots If applicable, add screenshots to help explain your problem. Screenshot 2024-10-14 113458

VS Code Extension Information (please complete the following information): Version: 1.94.2 (user setup) Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427 Date: 2024-10-09T16:08:44.566Z Electron: 30.5.1 ElectronBuildId: 10262041 Chromium: 124.0.6367.243 Node.js: 20.16.0 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.22631

CLI Information (please complete the following information):

Additional context Add any other context about the problem here. We already have a ticket with Microsoft Azure AI Studio | 2410010010003807

yukun-dong commented 5 days ago

Hi @say-brad , Your repro steps seems nothing to do with Teams Toolkit. Can you try using Teams Toolkit's command: "Provision", "Deploy" and then see again if there are any issues?

say-brad commented 5 days ago

Hello Yashika,

can you follow below steps and update the thread?

Thanks, Sayee


From: yukun-dong @.> Sent: Thursday, October 17, 2024 00:01 To: OfficeDev/teams-toolkit @.> Cc: Sayeenath Sehar-Varadaraj @.>; Mention @.> Subject: Re: [OfficeDev/teams-toolkit] Teams Toolkit publish option does not work correctly (Issue #12518)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

[EXTERNAL]: Do not click links or open attachments unless you recognize the sender

Hi @say-bradhttps://github.com/say-brad , Your repro steps seems nothing to do with Teams Toolkit. Can you try using Teams Toolkit's command: "Provision", "Deploy" and then see again if there are any issues?

— Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/teams-toolkit/issues/12518#issuecomment-2418717239, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU2SGTGE7XHIJRX6SPXMWKDZ35OGFAVCNFSM6AAAAABP5TVBGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYG4YTOMRTHE. You are receiving this because you were mentioned.Message ID: @.***>

say-brad commented 4 days ago

Hello,

we tried, below is the results we get from teams tool kit.

[cid:87d092be-7143-4b21-a0b4-54a774fe947d]

Thanks, Sayee


From: Sayeenath Sehar-Varadaraj @.> Sent: Thursday, October 17, 2024 00:16 To: OfficeDev/teams-toolkit @.>; Yashika Goyal @.>; OfficeDev/teams-toolkit @.> Cc: Mention @.***> Subject: Re: [OfficeDev/teams-toolkit] Teams Toolkit publish option does not work correctly (Issue #12518)

Hello Yashika,

can you follow below steps and update the thread?

Thanks, Sayee


From: yukun-dong @.> Sent: Thursday, October 17, 2024 00:01 To: OfficeDev/teams-toolkit @.> Cc: Sayeenath Sehar-Varadaraj @.>; Mention @.> Subject: Re: [OfficeDev/teams-toolkit] Teams Toolkit publish option does not work correctly (Issue #12518)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

[EXTERNAL]: Do not click links or open attachments unless you recognize the sender

Hi @say-bradhttps://github.com/say-brad , Your repro steps seems nothing to do with Teams Toolkit. Can you try using Teams Toolkit's command: "Provision", "Deploy" and then see again if there are any issues?

— Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/teams-toolkit/issues/12518#issuecomment-2418717239, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU2SGTGE7XHIJRX6SPXMWKDZ35OGFAVCNFSM6AAAAABP5TVBGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYG4YTOMRTHE. You are receiving this because you were mentioned.Message ID: @.***>

iamyashikagoyal commented 4 days ago

I am following the steps, but I am still receiving the error,

FOR TESTTOOL: Everything is working!


FOR LOCAL: If i say hi, it is perfectly responding, Hello, How may i assist you today. But, I can see in the Terminal that If i am asking the bot any question related to the data we have fed, It is giving us the answers, but in the Output it throws an error that says citation character length limit exceeded: Also, if i say give me without citation or reference, it is working in LOCAL.

Screenshot 2024-10-17 075903 image Screenshot 2024-10-17 083751


FOR DEV: I can only see that even if i write hi or anything, i am recieving "Bot encountered an error" in the chat window. For your refernece, this is what it looks like:

Screenshot 2024-10-17 083240

swatDong commented 4 days ago

From your log, it seems you have unhandled azureopenai:app:error

image

By default teams toolkit app handles errors in adapter.onTurnError sample code like this

You can also adjust the error handling code to add your own logic.

iamyashikagoyal commented 4 days ago

image

@swatDong @yukun-dong @adashen The code came already setup when i downloaded the zip from Azure AI Studio, It shows citation.appearance.abstract exceeds the length limit. Is there anything in specific you want me to change? Because as i showed in the picture, that for local environment, if i am asking to give responses without citation, it is replying, but we need citations, and for dev env. it is simply responding error.

IAM5K commented 1 day ago

If you don want to send errors to user, comment these lines image

More over if you want to handle the error you need to look into the function throwing error.

iamyashikagoyal commented 1 day ago

@IAM5K i have already tried making changing to already present code. The problem is not it is giving me error, the problem is, because refereces are included in my answer, if the character limit goes up than 480, it crashes to theow error. It is handeling the error. I want to get rid of citations length limit exceeded error.

IAM5K commented 1 day ago

If possible please share your repo /code or share the source from where you cloned. I can check and let you know the possible solution

iamyashikagoyal commented 1 day ago

@IAM5K I created my bot on Azure AI Studio. And from there as a way to deploy i got the option to deploy it as a Team App. I clicked on it, and a zip file got downloaded.

Problem i am encountering is: https://github.com/OfficeDev/teams-toolkit/issues/12518#issuecomment-2419874571

adashen commented 2 hours ago

It seems the bug is caused by the source code in Open AI Bot Sample. So created the issue at https://github.com/microsoft/teams-ai/issues/2132 Please track there.