search

OfficeDev / teams-toolkit

Developer tools for building Teams apps
Other
466 stars 192 forks source link

feat: add schema validation for localization files #12537

Closed anchenyi closed 3 weeks ago

anchenyi commented 4 weeks ago

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/29870541

image

image

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.93%. Comparing base (ef1e054) to head (a73deb5). Report is 107 commits behind head on dev.

Files with missing lines Patch % Lines
.../fx-core/src/component/driver/teamsApp/validate.ts 97.82% 0 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12537/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #12537 +/- ## ========================================== + Coverage 89.66% 89.93% +0.26% ========================================== Files 583 571 -12 Lines 34668 33761 -907 Branches 6768 6696 -72 ========================================== - Hits 31085 30362 -723 + Misses 1588 1495 -93 + Partials 1995 1904 -91 ``` | [Files with missing lines](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12537?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [.../fx-core/src/component/driver/teamsApp/validate.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12537?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fdriver%2FteamsApp%2Fvalidate.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci90ZWFtc0FwcC92YWxpZGF0ZS50cw==) | `91.42% <97.82%> (+5.16%)` | :arrow_up: | ... and [52 files with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12537/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)