OfficeDev / teams-toolkit

Developer tools for building Teams apps
Other
457 stars 188 forks source link

findChannel taking minutes with only around 100 items in the storage #12563

Open tinsheep opened 4 hours ago

tinsheep commented 4 hours ago

Describe the bug As the conversation store grows, in order to search the store is taking a minute or more to return across all my environments

To Reproduce

1) Load your azure blob storage (StorageV2 (general purpose v2)) with 50- 100+ records from personal and channel conversationTypes and tenants and attempt to retrieve a specific channel id, e.g. try { channel = await notificationApp.notification.findChannel(c => Promise.resolve(c.info.id === requestBody.channelId)); 2) observe that the call can take a minute or more to retrieve the channel

Expected behavior

I would expect the findChannel to return in seconds with a relatively small number of records.

Screenshots If applicable, add screenshots to help explain your problem.

VS Code Extension Information (please complete the following information): Version: 1.94.2 (user setup) Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427 Date: 2024-10-09T16:08:44.566Z Electron: 30.5.1 ElectronBuildId: 10262041 Chromium: 124.0.6367.243 Node.js: 20.16.0 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.22631 TeamsFx version - 2.3.2

Additional context I was having a similar problem with getPagedInstallations and when I followed the guidance for setting the validationEnabled to false on the 2.3.2 fx version that really improved performance. Is there similar checking going on here or anything I can do to speed things up? I'm very thankful for this library so thank you for all the work, but, the time it takes for this call is not reasonable IMO.

microsoft-github-policy-service[bot] commented 4 hours ago

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.