search

OfficeDev / teams-toolkit

Developer tools for building Teams apps
Other
466 stars 192 forks source link

feat: add schema validation for default language file #12576

Closed anchenyi closed 3 weeks ago

anchenyi commented 3 weeks ago

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/29904765

Also added telemetry for localization errors image

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.94%. Comparing base (0b83296) to head (ef0a13e). Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
.../fx-core/src/component/driver/teamsApp/validate.ts 88.88% 0 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12576/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #12576 +/- ## ========================================== - Coverage 89.94% 89.94% -0.01% ========================================== Files 571 571 Lines 33794 33801 +7 Branches 6552 6706 +154 ========================================== + Hits 30397 30403 +6 Misses 1495 1495 - Partials 1902 1903 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12576?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...e/src/component/driver/teamsApp/utils/telemetry.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12576?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fdriver%2FteamsApp%2Futils%2Ftelemetry.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci90ZWFtc0FwcC91dGlscy90ZWxlbWV0cnkudHM=) | `100.00% <100.00%> (ø)` | | | [.../fx-core/src/component/driver/teamsApp/validate.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12576?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fdriver%2FteamsApp%2Fvalidate.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci90ZWFtc0FwcC92YWxpZGF0ZS50cw==) | `91.16% <88.88%> (-0.27%)` | :arrow_down: |