OfficeDev / teams-toolkit

Developer tools for building Teams apps
Other
466 stars 192 forks source link

feat: upgrade manifest to v1.19 #12577

Closed anchenyi closed 1 week ago

anchenyi commented 3 weeks ago

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/29920123

E2E test: https://github.com/OfficeDev/teams-toolkit/actions/runs/11589466428 No manifest related error.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.98%. Comparing base (5c1647c) to head (13e7a16). Report is 27 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12577/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #12577 +/- ## ======================================== Coverage 89.98% 89.98% ======================================== Files 574 574 Lines 33924 33924 Branches 6794 6674 -120 ======================================== Hits 30526 30526 Misses 1496 1496 Partials 1902 1902 ``` | [Files with missing lines](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12577?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...ckages/vscode-extension/src/migration/constants.ts](https://app.codecov.io/gh/OfficeDev/teams-toolkit/pull/12577?src=pr&el=tree&filepath=packages%2Fvscode-extension%2Fsrc%2Fmigration%2Fconstants.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvdnNjb2RlLWV4dGVuc2lvbi9zcmMvbWlncmF0aW9uL2NvbnN0YW50cy50cw==) | `100.00% <100.00%> (ø)` | |
HuihuiWu-Microsoft commented 2 weeks ago

Will you also update samples?

anchenyi commented 2 weeks ago

Will you also update samples?

@HuihuiWu-Microsoft Yes, I will also update the samples.