search

OfficeDev / xblock-officemix

MIT License
10 stars 9 forks source link

Add pylint and pep8 configuration, fix issues #7

Closed tusbar closed 8 years ago

tusbar commented 8 years ago

Hey,

Here’s another PR that fixes a few pep8 and pylint issues.

cc @kurtb

msftclas commented 8 years ago

Hi @tusbar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

tusbar commented 8 years ago

@kurtb It could also be interesting to add some kind of CI (travis, circle, etc.) that assesses code quality (runs pylint and pep8) on each PR.

kurtb commented 8 years ago

Totally agree.

Any suggestions for what most people are using for this sort of thing? Or a repo that you think is a good example of how to do this?

We're mostly .NET types around here so could definitely use some Python suggestions :)