Closed Riccorbypro closed 1 year ago
god damnit.
Edit: the version in the config is solely there if i change things in the config system and layout that may cause crashes or other problems. The actual application version is stored inside the main.py file.
The issue should be fixed. Please run it again and let it update and report back if it still wants to act funny. Turns out there was a rogue =
.
I consider this issue resolved. If you encounter the bug again comment on the issue and i will reopen it.
Describe the bug When using the auto updater, the update applies correctly. However, the auto updater still shows the application as outdated.
To Reproduce
Expected behavior The auto updater should not prompt you to update when you are on the latest version
Screenshots![image](https://github.com/Official-Husko/NN-Downloader/assets/13792979/da635c73-416a-4cef-8923-063d8e464718)
Used Parameters and Settings (please complete the following information): N/A
Additional context I believe this issue is caused by a mismatch between the versioning provided by the GitHub API and checking against the version in the config file. I did try to modify the config version to
1.4.0
, however this is not valid JSON as the version is currently stored asfloat
.This is from a quick glance through the code though and could be completely wrong - I'm not familiar with python.