search

Official-Husko / NN-Downloader

Easily download all of your favorite Naughty images from multiple sites.
Mozilla Public License 2.0
48 stars 9 forks source link

[BUG] Folder Name Length causing crash #38

Closed KayJay95 closed 3 months ago

KayJay95 commented 3 months ago

The Bug If you run the Downloader with tags longer than 256 char it breaks as the output folder name cant be longer then that.

Error [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'media/22-06-202412-52-58-vore-death-flash-fart-nipplevore-breastexpansion-vorepov-unbirthing-pooping-body_sizegrowth-urine-soiling-muscular_-bigbreasts-bigpenis-thick_thighs_de4dm1lk_fleurfurr_lettuce_artist_kind_lurker_ssevisx_81yffulfmm_noxxlss_ruffruffles_lintwave_4hazelstreet_uricomics_dudles_codyblue-731_100racs_replicant_skrunkle_lemonbird_rilesthecat_entom_kyufuru_lyonley_slashkill_domibun_lilmoonie'

To Reproduce

  1. Run the Downloader
  2. Select e621
  3. Type in any tags as long as they are, in total, longer than 256 characters
  4. See error

Expected behavior Downloader should run normally (maybe allow users to name output folders / change them, as planned in #31)

Screenshot image

Desktop:

Used Parameters and Settings:

runtime.log runtime.log

Official-Husko commented 3 months ago

god damnit, i knew this would come around to bite me in the ass. I will push a quick fix to address the issue.

Thanks for the report!

Official-Husko commented 3 months ago

Is it possible that the tags you provided have no results? While testing to see if the issue was resolved i saw that there are no results with these tags.

Official-Husko commented 3 months ago

@KayJay95 do me a favor and try this build. If it works i can fully release it. nn-downloader-windows.zip

KayJay95 commented 3 months ago

@Official-Husko Sorry it took me this long to respond, yes the version works perfectly, thank you :D 👍 image