search

OfficialIncubo / BeatDrop-Music-Visualizer

The Milkdrop2 Music Visualization Standalone, only for Windows
https://twitter.com/BeatDropVis
Other
40 stars 2 forks source link

Three things #2

Closed milkdropper closed 1 year ago

milkdropper commented 2 years ago

I thought I submitted this issue already but can't see it now. If I duplicated anything, sorry.

I have three things: 1) It's great you are moving this project forward! It seems the original maintainer has gone silent. 2) Could you implement this PR for multiple monitor support? https://github.com/mvsoft74/BeatDrop/pull/4 3) Can you give an option to toggle unlimited FPS? I am on a 244hz monitor and getting 200+FPS. This looks really nice for some presets, but others act like they are going way too fast. This is because many presets are based on the FPS counter which is expected to be 60 and were designed originally on 60.

Thanks!

milkdrop2077 commented 2 years ago

hey milkdropper, I can't test the unlimited FPS feature because my screen only support 60fps, do you have the same problem with my version BeatDrop2077? I could implement an option for that. Do you have this problem with the milkdrop version (MilkDrop v2.33.2+) of wacup? it's limited to 144fps, and wacup has some extra code like UpdateMaxFps in the file config.cpp

milkdrop2077 commented 2 years ago

I thought I submitted this issue already but can't see it now. If I duplicated anything, sorry.

I have three things:

1. It's great you are moving this project forward! It seems the original maintainer has gone silent.

2. Could you implement this PR for multiple monitor support? [Implement support for multiple monitors mvsoft74/BeatDrop#4](https://github.com/mvsoft74/BeatDrop/pull/4)

3. Can you give an option to toggle unlimited FPS? I am on a 244hz monitor and getting 200+FPS. This looks really nice for some presets, but others act like they are going way too fast. This is because many presets are based on the FPS counter which is expected to be 60 and were designed originally on 60.

Thanks!

Also I've implemented your ALT+SHIFT stretching code into my version of BeatDrop2077, it seems to work well but I don't have multiple monitor to test it so please let me know if it works like it should be!

OfficialIncubo commented 2 years ago

My laptop's monitor runs 144 FPS on it because it has 144hz. I should do an action, such as multiple monitor stretch and always on top feature while I come back home.

OfficialIncubo commented 2 years ago

Done! Look at these commits:

OfficialIncubo commented 2 years ago

Ok, @milkdropper, for toggling the Unlimited FPS on and off, what hotkey should I specify?

When off, the framerate should change to 0 to the max_fps_w and max_fps_fs read from milk2.ini.

OfficialIncubo commented 1 year ago

Alright. @milkdrop2077 now implemented this feature and this code will be released in the future or later (F3 hotkey).

I will close this issue right now.

OfficialIncubo commented 1 year ago

Can you give an option to toggle unlimited FPS? I am on a 244hz monitor and getting 200+FPS. This looks really nice for some presets, but others act like they are going way too fast. This is because many presets are based on the FPS counter which is expected to be 60 and were designed originally on 60.

Hey, @milkdropper! I have implemented my own version of toggle 30/60/90... fps! You can check my commit now: https://github.com/mvsoft74/BeatDrop/commit/75af8fdcc92ff19df92a3dd8620682a622328f57

So, It's very easy for me to implement it. What do you think? ...and the 1.2.3 version is now RELEASED!