Run code through shellcheck and maybe shfmt

Offirmo / offirmo-shell-lib

A collection of useful bash reusable functions for robust and advanced shell scripts. Used to power cvm and simpli.

The Unlicense

25 stars 2 forks source link

Run code through shellcheck and maybe shfmt #2

Open docwhat opened 2 years ago

docwhat commented 2 years ago

At the very least, you should consider running the code through cd bin ; shellcheck --shell=bash *.sh ... a quick count fount 225 issues, including lots of variables being used without double quotes to prevent white-space issues.

shfmt is also nice and will fix a bunch of errors, but it'll ruin your nice formatting in a few places.

Offirmo commented 2 years ago

Hi, I'm not actively writing bash scripts at the moment. Are you using my lib or just reporting friendly?

docwhat commented 2 years ago

Just being friendly. 😃