Closed AlexandreG-tech closed 9 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
back-office | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 9, 2024 3:05pm |
marketplace | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 9, 2024 3:05pm |
PR Description updated to latest commit (https://github.com/Offline-Project/marketplace/commit/f1b78554ad87ea34711273b4ebce5612c160dcf3)
💡 General suggestions: The changes introduced in this PR seem to be well thought out and are likely to enhance the functionality of the application. However, it would be beneficial to ensure that all changes are thoroughly tested, especially those related to the handling of Ethereum addresses and the stripe process. Additionally, it would be helpful to include more detailed comments in the code to explain the purpose and functionality of the new features and changes.
Utilizing extra instructionsThe `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'general suggestions' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. |
How to enable\disable automation- When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations |
Auto-labelsThe `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag) |
Extra sub-toolsThe `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more. |
Auto-approve PRsBy invoking: ``` /review auto_approve ``` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: ``` [pr_reviewer] enable_auto_approval = true ``` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: ``` [pr_reviewer] maximal_review_effort = 5 ``` |
More PR-Agent commands> To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \ |
User description
…alContractButton and mock next/cache for test in updateEventPassCart
EventPasses.tsx and PasCardSelect.tsx : added NextIntlProvider
migration: change order_amount_handling to not count quantity on update
payment-admin: integration tests to make sure stripeCheckoutSession is deleted if the execution of the function goes right
updateEventPassCart: change migration to not count existing pendingOrder quantity in total quantity and added tests for those edge cases
cart/purchase : reason in search params
stripe process: add button and action to cancel a purchase order and a stripe session, added tests for the getStripeActiveCheckoutSession function and especially the no user/user mail case
lowercase for all eth addresses : update tests and add migration for the insert trigger ; make the cancel my purchase button reactive
Type
Enhancement
Changes walkthrough
17 files
nftActivity.integration.test.ts
Update
fromAddress
andtoAddress
to use lowercase addresses innftActivity.integration.test.ts
libs/indexer/alchemy/webhooks/src/lib/nftActivity.integration.test.ts
fromAddress
andtoAddress
values in themockActivity
andmockActivity2
objects to use lowercase addresses.packCollection.integration.test.ts
Update
contractAddress
to use lowercase addresses inpackCollection.integration.test.ts
libs/nft/thirdweb-organizer/src/packCollection.integration.test.ts
contractAddress
values in themockActivity
andmockActivity2
objects to use lowercase addresses.pendingOrder.spec.ts
Add
eventPass3
and test case for updating order with new quantity inpendingOrder.spec.ts
libs/gql/user/api/src/queries/cart/pendingOrder.spec.ts
eventPass3
object with a lowercasecontractAddress
value.that exceeds the max limit.
payment-admin.integration.test.ts
Add integration tests for
confirmedStripeCheckoutSession
inpayment-admin.integration.test.ts
libs/payment/admin/src/lib/payment-admin.integration.test.ts
confirmedStripeCheckoutSession
function.
BoundedNumericStepper.tsx
Refactor
BoundedNumericStepper
to usevalue
prop andonChange
callbackin
BoundedNumericStepper.tsx
libs/ui/components/src/lib/bounded-numeric-stepper/BoundedNumericStepper.tsx
useState
hook and replaced it with avalue
prop andonChange
callback.increment
anddecrement
functions to use thevalue
propand
onChange
callback.UserCart.tsx
Add `reason` prop and section to `UserCart` in `UserCart.tsx`
libs/features/cart/src/lib/UserCart/UserCart.tsx
reason
toUserCartProps
andUserCart
component.UserCart
to display an alert ifreason
prop isprovided.
PassCardSelect.tsx
Add `value` prop to `PassCardSelect` in `PassCardSelect.tsx`
libs/features/organizer/event/src/lib/molecules/PassCard/PassCardSelect.tsx
value
toPassCardSelectProps
andPassCardSelectContent
component.PassCardSelectContent
component to use thevalue
prop.PassPurchaseHeader.tsx
Add
CancelPurchaseButton
component toPassPurchaseHeader
inPassPurchaseHeader.tsx
libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/PassPurchaseHeader.tsx
CancelPurchaseButton
to handle canceling apurchase order.
PurchaseInProgressAlert
component to include theCancelPurchaseButton
.CancelPurchaseButtonClient.tsx
Add
CancelPurchaseButton
component to handle canceling a purchaseorder in
CancelPurchaseButtonClient.tsx
libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/CancelPurchaseButtonClient.tsx
CancelPurchaseButton
to handle canceling apurchase order.
CartCancelled.stories.tsx
Add story for
CartCancelled
component with cancel purchase button inCartCancelled.stories.tsx
libs/features/cart/src/lib/CartCancelled/CartCancelled.stories.tsx
CartCancelled
component with cancel purchasebutton.
action.ts
Add
cancelPurchaseForUser
function to handle canceling a purchaseorder in
action.ts
libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/action.ts
cancelPurchaseForUser
to handle canceling apurchase order.
getStripeActiveCheckoutSession.ts
Update
getStripeActiveCheckoutSession
to throw error if user has noemail in
getStripeActiveCheckoutSession.ts
libs/features/payment-api/src/lib/getStripeActiveCheckoutSession.ts
getStripeActiveCheckoutSession
function to throw an errorif the user has no email.
updateEventPassCart.ts
Update
updateEventPassCart
to revalidate tags inupdateEventPassCart.ts
libs/features/organizer/event-actions/src/lib/updateEventPassCart.ts
updateEventPassCart
function to revalidate tags even whenrunning in Jest.
PassPurchase.stories.tsx
Update
WithPurchaseInProcess
story to include cancel purchase buttonin
PassPurchase.stories.tsx
libs/features/organizer/event/src/lib/pages/PassPurchase/PassPurchase.stories.tsx
WithPurchaseInProcess
story to include the cancel purchasebutton.
EventPassNftFilesTableClient.tsx
Return
null
ifdata
array is empty inEventPassNftFilesTableClient.tsx
libs/features/back-office/events/src/lib/molecules/EventPassNftFilesTable/EventPassNftFilesTableClient.tsx - Added a check to return `null` if the `data` array is empty.
EventPassCardFooter.tsx
Replace `_locale` with `locale` in `EventPassCardFooter.tsx`
libs/features/back-office/events/src/lib/molecules/EventPassCardFooter/EventPassCardFooter.tsx
_locale
variable and replaced it withlocale
variable.getStripeActiveCheckoutSession.spec.ts
Add unit tests for
getStripeActiveCheckoutSession
ingetStripeActiveCheckoutSession.spec.ts
libs/features/payment-api/src/lib/getStripeActiveCheckoutSession.spec.ts
getStripeActiveCheckoutSession
function.✨ Usage guide:
**Overview:** The `describe` tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L46) related to the describe tool (`pr_description` section), use the following template: ``` /describe --pr_description.some_config1=... --pr_description.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_description] some_config1=... some_config2=... ```
Enabling\disabling automation
- When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the describe tool is: ``` pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] ``` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. - Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: ``` pr_commands = ["/describe --pr_description.use_description_markers=true", ...] ``` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: - `type`: the PR type. - `summary`: the PR summary. - `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify [custom labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md#handle-custom-labels-from-the-repos-labels-page-gem) in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: - `Main topic:performance` - pr_agent:The main topic of this PR is performance - `New endpoint` - pr_agent:A new endpoint was added in this PR - `SQL query` - pr_agent:A new SQL query was added in this PR - `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile - ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: - `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. - `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. - `false` (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions
The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: ``` [pr_description] extra_instructions=""" - The PR title should be in the format: '
More PR-Agent commands
> To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \