OfflineHQ / marketplace

https://offline.live/
GNU General Public License v3.0
0 stars 0 forks source link

eventPassCardFooter: add next intl provider for EventPassContractReve… #271

Closed AlexandreG-tech closed 9 months ago

AlexandreG-tech commented 9 months ago

User description

…alContractButton and mock next/cache for test in updateEventPassCart

EventPasses.tsx and PasCardSelect.tsx : added NextIntlProvider

migration: change order_amount_handling to not count quantity on update

payment-admin: integration tests to make sure stripeCheckoutSession is deleted if the execution of the function goes right

updateEventPassCart: change migration to not count existing pendingOrder quantity in total quantity and added tests for those edge cases

cart/purchase : reason in search params

stripe process: add button and action to cancel a purchase order and a stripe session, added tests for the getStripeActiveCheckoutSession function and especially the no user/user mail case

lowercase for all eth addresses : update tests and add migration for the insert trigger ; make the cancel my purchase button reactive


Type

Enhancement


Changes walkthrough

Relevant files
Enhancement
17 files
nftActivity.integration.test.ts
Update fromAddress and toAddress to use lowercase addresses in
nftActivity.integration.test.ts

libs/indexer/alchemy/webhooks/src/lib/nftActivity.integration.test.ts
  • Updated the fromAddress and toAddress values in the mockActivity and
    mockActivity2 objects to use lowercase addresses.
  • packCollection.integration.test.ts
    Update contractAddress to use lowercase addresses in
    packCollection.integration.test.ts

    libs/nft/thirdweb-organizer/src/packCollection.integration.test.ts
  • Updated the contractAddress values in the mockActivity and
    mockActivity2 objects to use lowercase addresses.
  • pendingOrder.spec.ts
    Add eventPass3 and test case for updating order with new quantity in
    pendingOrder.spec.ts

    libs/gql/user/api/src/queries/cart/pendingOrder.spec.ts
  • Added eventPass3 object with a lowercase contractAddress value.
  • Added a test case to check the update of an order with a new quantity
    that exceeds the max limit.
  • payment-admin.integration.test.ts
    Add integration tests for confirmedStripeCheckoutSession in
    payment-admin.integration.test.ts

    libs/payment/admin/src/lib/payment-admin.integration.test.ts
  • Added integration tests for the confirmedStripeCheckoutSession
    function.
  • BoundedNumericStepper.tsx
    Refactor BoundedNumericStepper to use value prop and onChange callback
    in BoundedNumericStepper.tsx

    libs/ui/components/src/lib/bounded-numeric-stepper/BoundedNumericStepper.tsx
  • Removed the useState hook and replaced it with a value prop and
    onChange callback.
  • Updated the increment and decrement functions to use the value prop
    and onChange callback.
  • UserCart.tsx
    Add `reason` prop and section to `UserCart` in `UserCart.tsx`   

    libs/features/cart/src/lib/UserCart/UserCart.tsx
  • Added a new prop reason to UserCartProps and UserCart component.
  • Added a new section in UserCart to display an alert if reason prop is
    provided.
  • PassCardSelect.tsx
    Add `value` prop to `PassCardSelect` in `PassCardSelect.tsx`     

    libs/features/organizer/event/src/lib/molecules/PassCard/PassCardSelect.tsx
  • Added a new prop value to PassCardSelectProps and
    PassCardSelectContent component.
  • Updated the PassCardSelectContent component to use the value prop.
  • PassPurchaseHeader.tsx
    Add CancelPurchaseButton component to PassPurchaseHeader in
    PassPurchaseHeader.tsx

    libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/PassPurchaseHeader.tsx
  • Added a new component CancelPurchaseButton to handle canceling a
    purchase order.
  • Updated the PurchaseInProgressAlert component to include the
    CancelPurchaseButton.
  • CancelPurchaseButtonClient.tsx
    Add CancelPurchaseButton component to handle canceling a purchase
    order in CancelPurchaseButtonClient.tsx

    libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/CancelPurchaseButtonClient.tsx
  • Added a new component CancelPurchaseButton to handle canceling a
    purchase order.
  • CartCancelled.stories.tsx
    Add story for CartCancelled component with cancel purchase button in
    CartCancelled.stories.tsx

    libs/features/cart/src/lib/CartCancelled/CartCancelled.stories.tsx
  • Added a new story for CartCancelled component with cancel purchase
    button.
  • action.ts
    Add cancelPurchaseForUser function to handle canceling a purchase
    order in action.ts

    libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/action.ts
  • Added a new function cancelPurchaseForUser to handle canceling a
    purchase order.
  • getStripeActiveCheckoutSession.ts
    Update getStripeActiveCheckoutSession to throw error if user has no
    email in getStripeActiveCheckoutSession.ts

    libs/features/payment-api/src/lib/getStripeActiveCheckoutSession.ts
  • Updated the getStripeActiveCheckoutSession function to throw an error
    if the user has no email.
  • updateEventPassCart.ts
    Update updateEventPassCart to revalidate tags in
    updateEventPassCart.ts

    libs/features/organizer/event-actions/src/lib/updateEventPassCart.ts
  • Updated the updateEventPassCart function to revalidate tags even when
    running in Jest.
  • PassPurchase.stories.tsx
    Update WithPurchaseInProcess story to include cancel purchase button
    in PassPurchase.stories.tsx

    libs/features/organizer/event/src/lib/pages/PassPurchase/PassPurchase.stories.tsx
  • Updated the WithPurchaseInProcess story to include the cancel purchase
    button.
  • EventPassNftFilesTableClient.tsx
    Return null if data array is empty in EventPassNftFilesTableClient.tsx

    libs/features/back-office/events/src/lib/molecules/EventPassNftFilesTable/EventPassNftFilesTableClient.tsx - Added a check to return `null` if the `data` array is empty.
    EventPassCardFooter.tsx
    Replace `_locale` with `locale` in `EventPassCardFooter.tsx`     

    libs/features/back-office/events/src/lib/molecules/EventPassCardFooter/EventPassCardFooter.tsx
  • Removed the _locale variable and replaced it with locale variable.
  • getStripeActiveCheckoutSession.spec.ts
    Add unit tests for getStripeActiveCheckoutSession in
    getStripeActiveCheckoutSession.spec.ts

    libs/features/payment-api/src/lib/getStripeActiveCheckoutSession.spec.ts
  • Added unit tests for the getStripeActiveCheckoutSession function.

  • ✨ Usage guide:
    **Overview:** The `describe` tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L46) related to the describe tool (`pr_description` section), use the following template: ``` /describe --pr_description.some_config1=... --pr_description.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_description] some_config1=... some_config2=... ```
    Enabling\disabling automation
    - When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the describe tool is: ``` pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] ``` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. - Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: ``` pr_commands = ["/describe --pr_description.use_description_markers=true", ...] ``` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: - `type`: the PR type. - `summary`: the PR summary. - `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
    Custom labels
    The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify [custom labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md#handle-custom-labels-from-the-repos-labels-page-gem) in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: - `Main topic:performance` - pr_agent:The main topic of this PR is performance - `New endpoint` - pr_agent:A new endpoint was added in this PR - `SQL query` - pr_agent:A new SQL query was added in this PR - `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile - ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
    Inline File Walkthrough 💎
    For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: - `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. - `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. - `false` (default): File changes walkthrough will be added only to the "Conversation" tab.
    Utilizing extra instructions
    The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: ``` [pr_description] extra_instructions=""" - The PR title should be in the format: ': ' - The title should be short and concise (up to 10 words) - ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [describe usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vercel[bot]"><img src="https://avatars.githubusercontent.com/in/8329?v=4" />vercel[bot]</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <p><strong>The latest updates on your projects</strong>. Learn more about <a href="https://vercel.link/github-learn-more">Vercel for Git ↗︎</a></p> <table> <thead> <tr> <th style="text-align: left;">Name</th> <th style="text-align: left;">Status</th> <th style="text-align: left;">Preview</th> <th style="text-align: left;">Comments</th> <th style="text-align: left;">Updated (UTC)</th> </tr> </thead> <tbody> <tr> <td style="text-align: left;"><strong>back-office</strong></td> <td style="text-align: left;">✅ Ready (<a href="https://vercel.com/offline/back-office/4GYmXtrqyMYECvDmiY5oUzkpuv4h">Inspect</a>)</td> <td style="text-align: left;"><a href="https://vercel.live/open-feedback/back-office-git-267-26012024-bug-report-offline.vercel.app?via=pr-comment-visit-preview-link&passThrough=1">Visit Preview</a></td> <td style="text-align: left;">💬 <a href="https://vercel.live/open-feedback/back-office-git-267-26012024-bug-report-offline.vercel.app?via=pr-comment-feedback-link"><strong>Add feedback</strong></a></td> <td style="text-align: left;">Feb 9, 2024 3:05pm</td> </tr> <tr> <td style="text-align: left;"><strong>marketplace</strong></td> <td style="text-align: left;">✅ Ready (<a href="https://vercel.com/offline/marketplace/DMciWDVBpyKXmFNUQ5uPi5dmYsgQ">Inspect</a>)</td> <td style="text-align: left;"><a href="https://vercel.live/open-feedback/marketplace-git-267-26012024-bug-report-offline.vercel.app?via=pr-comment-visit-preview-link&passThrough=1">Visit Preview</a></td> <td style="text-align: left;">💬 <a href="https://vercel.live/open-feedback/marketplace-git-267-26012024-bug-report-offline.vercel.app?via=pr-comment-feedback-link"><strong>Add feedback</strong></a></td> <td style="text-align: left;">Feb 9, 2024 3:05pm</td> </tr> </tbody> </table> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent-free[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent-free[bot]</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <p><strong><a href="https://github.com/Offline-Project/marketplace/pull/271">PR Description</a></strong> updated to latest commit (<a href="https://github.com/Offline-Project/marketplace/commit/f1b78554ad87ea34711273b4ebce5612c160dcf3">https://github.com/Offline-Project/marketplace/commit/f1b78554ad87ea34711273b4ebce5612c160dcf3</a>)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent-free[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent-free[bot]</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <h2>PR Analysis</h2> <ul> <li>🎯 <strong>Main theme:</strong> This PR primarily focuses on enhancing the functionality of the application by introducing new features and making changes to existing ones. The changes include adding a new international provider for EventPassContractRevealContractButton, modifying the order_amount_handling migration, adding integration tests for stripeCheckoutSession, and updating the eventPassCart. It also includes changes to the stripe process, such as adding a button and action to cancel a purchase order and a stripe session.</li> <li>📝 <strong>PR summary:</strong> The PR introduces several enhancements to the application, including changes to the order handling process, the addition of new tests, and the introduction of new features. The changes are spread across multiple files and include modifications to the handling of Ethereum addresses, the addition of a new international provider, and updates to the stripe process.</li> <li>📌 <strong>Type of PR:</strong> Enhancement</li> <li>🧪 <strong>Relevant tests added:</strong> Yes</li> <li>⏱️ <strong>Estimated effort to review [1-5]:</strong> 4, because the PR includes changes to multiple files and introduces new functionality. The changes are also spread across different aspects of the application, including the handling of Ethereum addresses, the order handling process, and the stripe process.</li> <li>🔒 <strong>Security concerns:</strong> No <h2>PR Feedback</h2></li> </ul> <p><strong>💡 General suggestions:</strong> The changes introduced in this PR seem to be well thought out and are likely to enhance the functionality of the application. However, it would be beneficial to ensure that all changes are thoroughly tested, especially those related to the handling of Ethereum addresses and the stripe process. Additionally, it would be helpful to include more detailed comments in the code to explain the purpose and functionality of the new features and changes.</p> <hr> <details> <summary><strong>✨ Usage guide:</strong></summary><hr> **Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'general suggestions' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> How to enable\disable automation</strong></summary><hr> - When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations </details></td></tr> <tr><td><details> <summary><strong> Auto-labels</strong></summary><hr> The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag) </details></td></tr> <tr><td><details> <summary><strong> Extra sub-tools</strong></summary><hr> The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more. </details></td></tr> <tr><td><details> <summary><strong> Auto-approve PRs</strong></summary><hr> By invoking: ``` /review auto_approve ``` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: ``` [pr_reviewer] enable_auto_approval = true ``` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: ``` [pr_reviewer] maximal_review_effort = 5 ``` </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [review usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>