OfflineIMAP / offlineimap3

Read/sync your IMAP mailboxes (python3)
Other
455 stars 64 forks source link

Import fcntl #171

Closed sudipm-mukherjee closed 11 months ago

sudipm-mukherjee commented 11 months ago

imaplibutil does not use portalocker, so only try to import fcntl and try to use it.

This v1.1 template stands in .github/.

This PR

Add character x [x].

References

Additional information

This has now been reported in Debian also at https://bugs.debian.org/1057921 and is very easy to reproduce the failure. This patch has been tested with the scenaio of https://bugs.debian.org/1057921.

thekix commented 11 months ago

Dear @sudipm-mukherjee

In the requirements.txt file there is this line:

portalocker[cygwin]

Therefore, probably portalocker is used in cygwin. I am not sure, because I am not using cygwin. Could we confirm that?

Best regards, kix

sudipm-mukherjee commented 11 months ago

@thekix ok, but I am not seeing any reference of portalocker in imaplibutil.py. Whereas here its being used https://github.com/OfflineIMAP/offlineimap3/blob/master/offlineimap/accounts.py#L238. I maybe wrong.

thekix commented 11 months ago

@sudipm-mukherjee Yes, portalocker is not used in this file (https://github.com/search?q=repo%3AOfflineIMAP%2Fofflineimap3%20portalocker&type=code). Probably we can apply this patch and create a new one to remove portalocker from UIDMaps.py