OffsetMods538 / Better-Multishot

Makes multishot better
MIT License
0 stars 1 forks source link

[Suggestion] Crossbow item loading and mod compat #7

Open Ultimushadow opened 1 year ago

Ultimushadow commented 1 year ago

When I first installed the mod I interpreted the line "How about shooting 7 eggs/ender pearls/experience bottles/potions/snowballs at once?" a little differently from how it's implemented in game. As you can guess from the issue title, I expected the crossbow to be able to load these items, which I still think is a fantastic idea! When loaded, they could show a different texture on the crossbow itself (similar to how Supplementaries changes the texture when loading a spectral arrow), and be affected by multishot. I think one could argue against this for the experience bottle as, at that point, it's just a 7x multiplier on experience, but to be honest I don't actually know how broken that would be in comparison to like.. vanilla xp farms. Xp bottles aren't exactly falling out of a mob grinder, ya know? And if need be, I think a config option to enable/disable certain items would be great to implement alongside this.

Speaking of config, I wonder if you would be able to implement a way to add other mod's thrown items through a config, so you didn't have to hardcode if someone was looking to compat the mods. I don't know exactly how you coded this, but mods like Iceball, Supplementaries, Better Archeology, etc. have throwable items that could be added to the list you have currently with vanilla items. Allowing the user to add this through config also prevents any accidental unbalanced combinations, like throwable items which place blocks that would then be duplicated. Let me know what you think!

OffsetMonkey538 commented 1 year ago

Not sure about the crossbow item loading part. I do like the idea of mod compatibility. I want to make it compatible with my croissant mod anyway, so finding a way to just make everything compatible would be really nice. Not sure how exactly that would work though as I need to mixin the specific item class and specify, in code, the projectile for that item.

Btw, it would probably be easier to chat on discord

OffsetMonkey538 commented 1 year ago

And I'm pretty sure the mod should be able to work server-side only and to make the items shoot from a crossbow, I would probably need to like create textures with the item inside the crossbow