Ofosu-Osei / seaborn_objects_recipes

seaborn_objects_recipes is a Python package that extends the functionality of the Seaborn library, providing custom recipes for enhanced data visualization. This package includes below features to augment your Seaborn plots with additional capabilities.
MIT License
8 stars 1 forks source link

Polyfit update to reflect recent requirements #11

Closed Ofosu-Osei closed 3 months ago

nickeubank commented 3 months ago

THANKS! Comments soon

nickeubank commented 3 months ago

Does this address #1? Looks like you moved to regular confidence intervals (cool!), but it still doesn't work as something you pass into an .add() method (e.g., .add(so.Lines, sor.Lowess()) or .add(so.Lines, sor.PolyFitWithCI()) does it?

Ofosu-Osei commented 3 months ago

Does this address #1? Looks like you moved to regular confidence intervals (cool!), but it still doesn't work as something you pass into an .add() method (e.g., .add(so.Lines, sor.Lowess()) or .add(so.Lines, sor.PolyFitWithCI()) does it?

You know what, I think I misinterpreted the example you provided that returned a plot. So I thought you wanted the recipes to be called independently with arguments. I can fix this by going back to the original implementation style. Thanks!

nickeubank commented 3 months ago

That's poor communication on my part — the example you link was a "throw-together" that did what I wanted in terms of output, but was in no way integrated into the modular/composable framework of seaborn.objects I want to move towards.

Also: Starting July 1 you can start billing time on this. Just let me know about every two weeks how much your billing (and you may bill whatever you've put in earlier this summer).

Ofosu-Osei commented 3 months ago

Message acknowledged, I'll work on it as soon as possible.