New Version can't read immigration before save and reload

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Let the game run with Therapist 0.52
2. Receive Immigration
3. Check Therapist for newly added dwarves

Closing and re-opening 0.52 didn't help, it would consistently only show 13
dwarves. When i opened 0.5 with added information for 0.31.4 it read 19
dwarves with no trouble. Closed and retried with 0.52, still 13.
0.5 had been opened prior to the immigration wave too; i've just received
news 0.52 was out.

As i read here that i should attach a save, i've saved and reloaded.
Therapist 0.52 then read all 19 dwarves, so it's not a very persistent
problem and attaching the save would be of no use.

Original issue reported on code.google.com by escalib...@gmail.com on 20 May 2010 at 9:08

[GoogleCodeExporter]

I've had another issue that's proven itself unreproducable.
The first time i ran 0.52, all working job skills disappeared from my dwarves 
ingame
[g]en. information, leaving the social skills.

Original comment by escalib...@gmail.com on 20 May 2010 at 9:12

[GoogleCodeExporter]

forgot to add: therapist 0.52 on win xp for df 31.04.

Original comment by escalib...@gmail.com on 20 May 2010 at 9:16

[GoogleCodeExporter]

Same issue running DT 0.5.2 on DF 0.31.04 on win7x64

New migrant wave of seven dwarves arrive, only one appears in DT. Telling DT to 
re-
read the dwarves doesn't work. Closing and re-opening DT doesn't work. I had to 
save 
and close and reopen and reload my save in DF, then reopen DT to get the new 
arrivals to show.

Original comment by bryanrut...@gmail.com on 20 May 2010 at 6:06

[GoogleCodeExporter]

This sounds like issue 218 is still open (or I caused it again)

Will look into this in more detail.

Original comment by treyst...@gmail.com on 20 May 2010 at 11:57

• Changed state: Accepted
• Added labels: Priority-High, Version-0.5.2, Milestone-0.5.3, Component-Logic
• Removed labels: Priority-Medium

[GoogleCodeExporter]

I think it may be a new bug -- in issue 218, a workaround was to close and 
reopen DT,
causing it to redo the on-connect memory region mapping. In this bug, closing 
and
reopening DT did not solve the problem.

I managed to reproduce the bug using the very helpful "migrants" savegame from 
issue
218, and ran DT with -trace and -debug, thus can verify it does correctly redo 
the
memory mapping every 20 seconds, as intended. Unfortunately, it doesn't seem to 
help. 

Complete run.log can be found at http://narc.ro/tmp/run.log (warning: 5.5 MB!) 
and
features the following points of interest:
 - migrants enter the map at around 08:38-ish. After they all came through, game
reported number of dwarves went from 49 to 68. 
 - I apparently did something weird at 08:40 by causing DT to re-read the game data
while the game was being saved (oops!), but strangely that did get me the 
expected
count of 68 (after which I got 64 while DF was sitting at the main menu. Note to
self: don't do stupid things like that).
 - Finally, at 08:41 I reloaded the savegame (having never exited DF) and DT now
correctly reports the new migrants.

Original comment by octavs...@gmail.com on 21 May 2010 at 5:48

[GoogleCodeExporter]

I just thought of this, and tried it, and I can further supply that the bug does
*not* occur for DF 0.31.03, so it might be that .04 moved some stuff around in 
memory.

Original comment by octavs...@gmail.com on 21 May 2010 at 6:09

[GoogleCodeExporter]

I frequently lose connection to the game with DT. I have to save the game, close
therapist, reopen the game, and then reopen therapist. This behavior must be 
repeated
to get migration waves to load as well.

Original comment by superrad...@gmail.com on 24 May 2010 at 11:32

[GoogleCodeExporter]

I'm thinking this has more to do with using an incorrect creature vector than 
anything. 
0.5.2 definitely shipped with a bogus one.

Fixed in r13ed26a2f010

Original comment by treyst...@gmail.com on 31 May 2010 at 8:16

• Changed state: Fixed