Ofunniku / dwarftherapist

Automatically exported from code.google.com/p/dwarftherapist
Other
0 stars 0 forks source link

[Linux] 0.5.5 does not compile #260

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. qmake dwarftherapist.pro
2. pro

What is the expected output? What do you see instead?

src/dfinstancelinux.cpp:138:6: error: prototype for ‘uint 
DFInstanceLinux::write_string(const uint&, const QString&)’ does not match 
any in class ‘DFInstanceLinux’
inc/dfinstancelinux.h:45:9: error: candidate is: virtual int 
DFInstanceLinux::write_string(const VIRTADDR&, const QString&)
src/dfinstancelinux.cpp:144:6: error: prototype for ‘uint 
DFInstanceLinux::write_int(const uint&, const int&)’ does not match any in 
class ‘DFInstanceLinux’
inc/dfinstancelinux.h:46:9: error: candidate is: virtual int 
DFInstanceLinux::write_int(const VIRTADDR&, const int&)
src/dfinstancelinux.cpp:278:6: error: prototype for ‘uint 
DFInstanceLinux::write_raw(const uint&, const uint&, void*)’ does not match 
any in class ‘DFInstanceLinux’
inc/dfinstancelinux.h:44:9: error: candidate is: int 
DFInstanceLinux::write_raw(const VIRTADDR&, const uint&, void*)

What version of the product are you using? On what operating system?

0.5.5, Archlinux

This seems to have been introduced in bdc40fcd53.
Patch with necessary change to get 0.5.5 as follows (no guarantees as to 
correctness):

--- dwarftherapist/src/dfinstancelinux.cpp      2010-06-28 07:51:20.372206589 
+0200
+++ dwarftherapist-build/src/dfinstancelinux.cpp        2010-06-28 
08:08:37.295026710 +0200
@@ -135,13 +135,13 @@
     return ret_val;
 }

-uint DFInstanceLinux::write_string(const uint &addr, const QString &str) {
+int DFInstanceLinux::write_string(const VIRTADDR &addr, const QString &str) {
     Q_UNUSED(addr);
     Q_UNUSED(str);
     return 0;
 }

-uint DFInstanceLinux::write_int(const uint &addr, const int &val) {
+int DFInstanceLinux::write_int(const VIRTADDR &addr, const int &val) {
     return write_raw(addr, sizeof(int), (void*)&val);
 }

@@ -275,7 +275,7 @@
 }
 */

-uint DFInstanceLinux::write_raw(const uint &addr, const uint &bytes, void 
*buffer) {
+int DFInstanceLinux::write_raw(const VIRTADDR &addr, const int &bytes, void 
*buffer) {
     // try to attach, will be ignored if we're already attached
     attach();

--- dwarftherapist/inc/dfinstancelinux.h        2010-06-28 07:51:20.348873106 
+0200
+++ dwarftherapist-build/inc/dfinstancelinux.h  2010-06-28 08:12:08.001664993 
+0200
@@ -41,7 +41,7 @@
     QString read_string(const VIRTADDR &addr);

     // Writing
-    int write_raw(const VIRTADDR &addr, const uint &bytes, void *buffer);
+    int write_raw(const VIRTADDR &addr, const int &bytes, void *buffer);
     int write_string(const VIRTADDR &addr, const QString &str);
     int write_int(const VIRTADDR &addr, const int &val);

Original issue reported on code.google.com by Jakob.Gr...@gmail.com on 28 Jun 2010 at 7:11

GoogleCodeExporter commented 9 years ago
Should read:

What steps will reproduce the problem?
1. qmake dwarftherapist.pro
2. *make*

Original comment by Jakob.Gr...@gmail.com on 28 Jun 2010 at 7:12

GoogleCodeExporter commented 9 years ago
I do not keep the source up to date with Linux, since windows is my primary 
environment. That said, thanks for the patch. But please don't file bugs for 
the linux version as it has never been officially released.

Original comment by treyst...@gmail.com on 28 Jun 2010 at 3:49