search

OgelGames / bones

A redo of the bones mod from Minetest Game
Other
2 stars 4 forks source link

Add option to disable item drops while bones_mode=bones #8

Closed Niklp09 closed 1 year ago

Niklp09 commented 1 year ago

Would fix problems like https://github.com/Archtec-io/bugtracker/issues/114

Explanation: This PR allows admins to disable the drop mode. For example on my server we only need the "bones" and "keep" mode as fallback.

OgelGames commented 1 year ago

This won't keep the items, the items are removed from the player's inventories here: https://github.com/OgelGames/bones/blob/04abd2458792e06863be0373edb2144e7e421c55/death.lua#L145

Might need to move the bone position check to before that function gets called.

Also, it would be better to make the setting bones_fallback_mode, as I've been thinking of adding a fourth option of creating a bones entity.

Niklp09 commented 1 year ago

bones_fallback_mode would be a bad name IMHO because the setting doesn't allow to set different modes, just enable/disable drop.

OgelGames commented 1 year ago

bones_fallback_mode would be a bad name IMHO because the setting doesn't allow to set different modes, just enable/disable drop.

That's my point, it should be like bones_mode. Currently the only options would be "drop" or "keep", but I intend to add another option sometime.

Niklp09 commented 1 year ago

@OgelGames I hope the name is now ok. bones_fallback_mode = true doesn't make much sense tbh