Move integration tests to a separate workspace crate to avoid MSRV is… - Githubissues

Ogeon / palette

A Rust library for linear color calculations and conversion

Apache License 2.0

749 stars 60 forks source link

Move integration tests to a separate workspace crate to avoid MSRV is… #356

Closed Ogeon closed 12 months ago

Ogeon commented 12 months ago

Due to an MSRV bump in memchr, I decided to move the integration tests to their own workspace crate.

codecov[bot] commented 12 months ago

Codecov Report

Merging #356 (ffcab42) into master (8a2fbfa) will decrease coverage by 0.23%. Report is 2 commits behind head on master. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   78.22%   78.00%   -0.23%     
==========================================
  Files         115      115              
  Lines       19751    19738      -13     
  Branches    19751    19738      -13     
==========================================
- Hits        15451    15396      -55     
- Misses       4074     4076       +2     
- Partials      226      266      +40

Files Changed	Coverage Δ
integration_tests/regression_tests/issue_283.rs	`0.00% <ø> (ø)`

... and 10 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codspeed-hq[bot] commented 12 months ago

CodSpeed Performance Report

Merging #356 will not alter performance

_{Comparing split_out_integration_tests (ffcab42) with master (8a2fbfa)}

Summary

✅ 40 untouched benchmarks

Ogeon commented 12 months ago

Well, the coverage report was helpful and notified me of the missing tests for wide :sweat_smile:

Ogeon commented 12 months ago

Looks like the remaining reduction in coverage are false positives.

bors r+

bors[bot] commented 12 months ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

ci