Closed Ogeon closed 7 months ago
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
4c97fb5
) 81.46% compared to head (6d96f73
) 81.50%. Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
palette/src/okhsl.rs | 96.07% | 4 Missing :warning: |
palette/src/okhwb.rs | 96.96% | 2 Missing :warning: |
palette/src/hues.rs | 99.05% | 1 Missing :warning: |
palette/src/okhsv.rs | 99.41% | 1 Missing :warning: |
palette/src/oklch.rs | 98.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:warning: No base runs were found
Falling back to comparing alloc_and_any_features_in_tests
(6d96f73) with master
(4c97fb5)
⚡ 1
improvements
❌ 1
regressions
✅ 43
untouched benchmarks
:warning: _Please fix the performance issues or acknowledge them on CodSpeed._
Benchmark | master |
alloc_and_any_features_in_tests |
Change | |
---|---|---|---|---|
❌ | matrix_inverse |
215.6 ns | 271.1 ns | -20.49% |
⚡ | multiply_3x3 |
427.8 ns | 372.2 ns | +14.93% |
@jonassmedegaard, you may want to have a look at this. I think I managed to find a good middle ground where the unit tests can run with any feature set. I didn't manage to get the doc-tests to work equally well, so I hope that's no issue.
A couple of things to keep in mind:
std
library during tests. Otherwise you would have to use either the "std"
or "libm"
feature. It may be possible to tweak it further to select libm
if the "std"
feature isn't set, though.~ Never mind, it should pick libm
now, if it's requested without std
."approx"
and "alloc"
. I set up the tests here with cargo hack
to also test pairs of features.I don't know if you are able to test run your setup on this branch, but I hope it will let you skip the patch.
Split out a separate
"alloc"
feature, that can be used without"std"
. This allows allocations on platforms that still allow them without thestd
library.Also makes it possible to run tests with any feature combination (without doc-tests, at the moment).
Closed Issues