Ogeon / palette

A Rust library for linear color calculations and conversion
Apache License 2.0
749 stars 60 forks source link

Fix typo about max range of u8 #374

Closed MultisampledNight closed 7 months ago

MultisampledNight commented 7 months ago

Unsigned integer values (u8, u16, u32, etc.) have a range from 0 to their largest representable value. For example 0u8 to 155u8 [...]

However, the largest value of u8 is not 155, it's 255. Chances are it's just been a typo.

No code was changed, only the documentation.

Ogeon commented 7 months ago

Yes, that's very much a typo. Thanks for spotting it and submitting a fix!

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c97fb5) 81.46% compared to head (5889047) 81.18%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #374 +/- ## ========================================== - Coverage 81.46% 81.18% -0.29% ========================================== Files 113 113 Lines 18438 17748 -690 Branches 18438 17748 -690 ========================================== - Hits 15021 14409 -612 + Misses 3220 3181 -39 + Partials 197 158 -39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 7 months ago

CodSpeed Performance Report

Merging #374 will degrade performances by 20.49%

:warning: No base runs were found

Falling back to comparing MultisampledNight:fix-typo (5889047) with master (4c97fb5)

Summary

❌ 1 regressions ✅ 44 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master MultisampledNight:fix-typo Change
matrix_inverse 215.6 ns 271.1 ns -20.49%
Ogeon commented 7 months ago

Ignore those two 😅