Ogeon / rustful

[OUTDATED] A light HTTP framework for Rust
https://docs.rs/rustful
Apache License 2.0
862 stars 52 forks source link

Context.uri is misleading #115

Closed hjr3 closed 8 years ago

hjr3 commented 8 years ago

I think https://github.com/Ogeon/rustful/blob/master/src/context/mod.rs#L148 is misleading.

According to https://tools.ietf.org/html/rfc3986 the URI contains something like

scheme:[//[user:password@]host[:port]][/]path[?query][#fragment]

In Rustful, calling context.uri only gives the path. Should we consider renaming that uri to path?

Ogeon commented 8 years ago

Yeah, that's probably a good Idea. The Uri type should also be renamed. Thanks for pointing it out :+1: