Remove support for rustc-serialize

Ogeon / rustful

[OUTDATED] A light HTTP framework for Rust

https://docs.rs/rustful

Apache License 2.0

862 stars 52 forks source link

Remove support for rustc-serialize #130

Closed ghost closed 7 years ago

ghost commented 7 years ago

Replace rustc-serialize integration with serde_json. Breaking changes:

removing read_json_body & decode_json_body from BodyReader

Fixes #123

Ogeon commented 7 years ago

If you write "Fixes #issuenumber" or "Closes #issuenumber" in your pull request description it will link and close it automatically.

ghost commented 7 years ago

Btw: this needs squashing

Ogeon commented 7 years ago

I'll do it when I'm merging.

Ogeon commented 7 years ago

By the way, just to be clear, the fixes or closes thing can be anywhere in the description, so you can write something more elaborate if you want to. Let me know when you are satisfied. :smile:

ghost commented 7 years ago

I'll write something :)

ghost commented 7 years ago

To me it's ready :)

Ogeon commented 7 years ago

Hold on, I missed that you put the serde dependencies under [dependencies]. They are only used in the example, so they should go under [dev-dependencies]. Sorry about that.

ghost commented 7 years ago

It's ok, I'll fix it.

Ogeon commented 7 years ago

Perfect! I'll merge when the tests are green. Thanks!

ghost commented 7 years ago

cool :)