Ogeon / rustful

[OUTDATED] A light HTTP framework for Rust
https://docs.rs/rustful
Apache License 2.0
862 stars 52 forks source link

Remove the logging system in favor of the Log crate #71

Closed Ogeon closed 8 years ago

Ogeon commented 8 years ago

Log has basically the same purpose as the loging system in the server, namely a common, user defined logger. I see no reason to keep the logging system around when Log is widely adopted and has an even more convenient API.

What should be done is:

The reason for using it in the examples is that I don't want to promote println! logging. Forced log printing is nasty and we don't want to look nasty, do we?

It's not the smallest task, but it shouldn't be too complicated.

kvikas commented 8 years ago

I still have to fix documentation on this. Can you review if this is what your plan was? Also this will break any client already using log module or context.log. Was this intended?

Ogeon commented 8 years ago

Yes, and that's ok. It will be released under a new 0.X version.