search

Ogeon / rustful

[OUTDATED] A light HTTP framework for Rust
https://docs.rs/rustful
Apache License 2.0
862 stars 52 forks source link

Minor todo example refactoring #92

Closed Eternity-Yarr closed 8 years ago

Eternity-Yarr commented 8 years ago

Added some meaningfulish error messages

Ogeon commented 8 years ago

This example is a little special, since it's an implementation of todobackend. It doesn't explicitly forbid helpful messages, so I think this will be fine. I'll add some comment, in the code, where I have questions or opinions.

Eternity-Yarr commented 8 years ago

Heh, I wasn't aware of such thing as todobackend. Maybe it's worth mention it somewhere in example?

Ogeon commented 8 years ago

Yes, that's a very good point. I didn't think about that when I wrote the example.

Ogeon commented 8 years ago

Here's a link to the test, in case you want to run it. Just input http://localhost:<port> to test a local server.

Ogeon commented 8 years ago

Alright, I'm done being picky now. It's a very good PR and the things I have commented on are far from show stopping, but I would appreciate it if you would address them in some way.

I see that I have also forgotten to add a welcome message that is displayed when the server starts. Would you mind adding it as well? I thought that it could be combined with a link to todobackend. Maybe even a direct link to the test. What do you think?

Ogeon commented 8 years ago

Very nice! I really like that welcome message. I'll just let the tests run and then it's ready to be merged. Thank you!

Eternity-Yarr commented 8 years ago

I'm glad to be useful :)

Ogeon commented 8 years ago

@homu r+

homu commented 8 years ago

:pushpin: Commit 7e8f1e8 has been approved by Ogeon

homu commented 8 years ago

:zap: Test exempted - status