search

OhMyAgnes / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

Glog defines GOOGLE_PREDICT_TRUE without checking if it has already been defined #179

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Include google protobuf headers (header that defines GOOGLE_PREDICT_TRUE is 
google\protobuf\stubs\common.h)
2. Include glog/logging.h

What is the expected output? What do you see instead?
Should compile cleanly.
warning C4005: 'GOOGLE_PREDICT_TRUE' : macro redefinition

What version of the product are you using? On what operating system?
0.3.3 on Windows 7

Please provide any additional information below.
This breaks the build when warnings are treated as errors.

Original issue reported on code.google.com by and...@spacemonkey.com on 8 Jan 2014 at 12:04

GoogleCodeExporter commented 8 years ago 
This is also true for GOOGLE_PREDICT_FALSE for protobuf version 3.0.0-alpha-1.

Original comment by schroed...@google.com on 12 Feb 2015 at 7:32