OhMyGuus / BetterCrewLink

Free, open, Among Us Proximity Chat
GNU General Public License v3.0
921 stars 161 forks source link

[BUG REPORT] Mute button issues #338

Closed JKohlman closed 2 years ago

JKohlman commented 2 years ago

Pre-Flight Checklist

Describe the bug

The mute button beside avatar/lobby doesn't always work

Steps to reproduce the behavior

Case 1

  1. Use Push-To-Talk (PTT) mode
  2. Enable mute
  3. Use PTT hotkey to speak
  4. Observe voice detection (VAD) and audio sent to other clients

Case 2

  1. Use PTT
  2. Enable mute
  3. Swap to Voice Activity (VA) mode
  4. Observe VAD and audio sent to other clients
  5. Toggle mute off/on to resolve

Expected behavior

While mute is turned on no voice should be transmitted. For case 1 PTT appears to be overriding the mute, for case 2 it appears the "muted" state is disabled internally but the button doesn't update.

Screenshots/Videos

No response

Desktop

N/A

Additional context

First reported by bubbub907