OhMyGuus / BetterCrewLink

Free, open, Among Us Proximity Chat
GNU General Public License v3.0
924 stars 161 forks source link

Potential incompatability with ExtraRoles mod #62

Closed JKohlman closed 3 years ago

JKohlman commented 3 years ago

Extra Roles has been shown to potentially cause issues with memory locations that BetterCrewLink looks for. I'm not sure if this is really feasible to fix but I'm noting it here so it's known.

OhMyGuus commented 3 years ago

Need someone with the actual issue to fix it, since I tested it with extra roles and it seemed to work for me.

MatadorProBr commented 3 years ago

and also this problem is not only with Extra Roles but with other mods, such as Town of Us

Jasbris commented 3 years ago

and also this problem is not only with Extra Roles but with other mods, such as Town of Us

Do you have to mod your root game folder (Steam/steamapps/common/Among Us), or will BetterCrewLink pick up a custom mod folder like "Steam/steamapps/common/Among Us - Town of Impostors"?

OhMyGuus commented 3 years ago

Better-Crewlink looks for the process called "Among Us.exe" in the process list, then it will make an handle and read memory from it. So the folder doesn't matter as long as you don't rename the actual exe.

However sometimes it bugs out, this because the mod changed some things after Crewlink started, so the best thing to get the mod working for BetterCrewlink is starting the modded game first and then Crewlink. If you do it like that it shouldn't cause an issue.

MatadorProBr commented 3 years ago

I will close this issue as it seems that the problem has been solved since I don't see anyone else reporting this bug