Oheers / EvenMoreFish

An advanced fishing plugin based on MoreFish, created 2 years after its last update.
MIT License
91 stars 56 forks source link

SERVER CRASH ERROR #182

Open madebygood opened 1 year ago

madebygood commented 1 year ago

image

It was fine until version 1.6.8, but the problem occurred from version 1.6.9.1.

When the fishing tournament is over, the server will be shut down.

Every update to this plugin increases bugs and reduces performance.

Why do you want to add Database?

Please develop it as a lightweight and well-optimized plugin.

Please don't add anything weird.

The server where hundreds of people were playing was rolled back 10 minutes ago, so I'm a bit angry, so please understand that the post can be offensive.

Oheers commented 1 year ago

I'm very sorry that this has caused such an annoyance for you and hundreds of other of players, I do try and keep large servers in mind when releasing updates - this wasn't the one where database was added and it's been in the plugin since 1.6, so I assumed this minor update wouldn't cause too many issues and it didn't on the test server.

This is one of the reasons why (bar this rather catastrophic bug report) the 1.6.9 update should reduce the likelihood of this happening as I'll be able to keep larger, more stability-risk updates in "beta/experimental" for longer until I can be sure they will be stable on larger servers such as yours. This is, after all, a personal programming project that I do in my free time rather than software developed by a large-scale company so I add stuff in that I would enjoy to use as an admin and enjoy to develop as a developer, hopefully this experimental-features setting should prevent this from getting in the way of stability going forward.

This is the top priority right now with the plugin as obviously it's making the plugin fail completely - I've got time tonight in which I'll have a deeper look at what's going wrong to cause the crash.

madebygood commented 1 year ago

thank you. evenmorefish is loved by many users including myself.

Thank you for work the time out of your busy schedule.

Oheers commented 1 year ago

Hey there, I've been trying to reproduce this so I can fix it but just genuinely am having no luck, even running a Purpur test server like yours is. Would you mind listing as many details about the crash you've got and I'll try and put together a similar server. Many thanks :)

madebygood commented 1 year ago

log.txt this is my log file.

EvenMoreFish.zip this is my config file.

Dozens or more are required to participate in the fishing competition.

Then, when the fishing tournament ends, the server shuts down.

Fishing tournament command: /emf admin competition start 700

This doesn't seem to have anything to do with purpur.

Even when I used the paper in the past, I had this experience with certain versions.

If there is anything else I need to explain, please let me know.

Oheers commented 1 year ago

Ah right cheers, I just used Purpur to try and get as exact a copy to your server as I could get.

I've just pusheda minor tweak to how the plugin checks if the database is enabled because it was originally running a little bit of code twice uneccessarily. The chance of this being the direct cause of such a fatal error is highly unlikely but it does correlate quite closely to the information provided by the stacktrace.

Oheers commented 1 year ago

This minor change can be downloaded in the latest dev build on the jenkins buildserver.

WongIong commented 1 year ago

tried dev build but not solved before it crash, it would spam the console [00:08:10 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:10 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:10 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead. [00:08:23 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:23 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:23 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead.

Anath4n commented 1 year ago

tried dev build but not solved before it crash, it would spam the console [00:08:10 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:10 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:10 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:18 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead. [00:08:23 ERROR]: [EvenMoreFish] No value in messages.yml for: fish-lore using default value instead. [00:08:23 ERROR]: [EvenMoreFish] No value in messages.yml for: fisherman-lore using default value instead. [00:08:23 ERROR]: [EvenMoreFish] No value in messages.yml for: length-lore using default value instead.

I also have this error in the console, it would help me a lot if you tell me how to remove this message

madebygood commented 10 months ago

image

I changed the version from 1.6.8 to 1.6.11.3 expecting it to be fixed now.

However, I am still having issues with the server crashing.

sarhatabaot commented 10 months ago

Just confirming, but this happens when using a mysql database or sqlite database, and when the competition ends, correct?

madebygood commented 10 months ago

Just confirming, but this happens when using a mysql database or sqlite database, and when the competition ends, correct?

image

Even if you set database to false, it will crash as well.

This is my setup.

How can this be resolved?

madebygood commented 10 months ago

This minor change can be downloaded in the latest dev build on the jenkins buildserver.

any good news?

ghost commented 10 months ago

its weird but enabling both experimental-features and database stops server from crashing instead it gives me database errors but nothing happens to server idk about performance

my full log: (dont care about the Attempted to place a tile entity thing its because of earth map) latest.log

restarting the server once after database created fixes the errors

sarhatabaot commented 10 months ago

I have a branch that fixes this. This is caused because the database should only be used when experimental features is enabled.

I'm going on vacation tomorrow but I should be able to push a fix on the 16th

ghost commented 10 months ago

restarting the server once after database created fixes the errors

my bad errors still persists

madebygood commented 9 months ago

I am waiting!

madebygood commented 8 months ago

This minor change can be downloaded in the latest dev build on the jenkins buildserver.

Has development of the plugin stopped?

Hundreds of users are requesting participation in fishing competitions.

sarhatabaot commented 8 months ago

Try this one https://github.com/Lapzupi/EvenMoreFish/releases/tag/latest

I can't really work on the plugin for the next month (maybe 2-3 months). So don't expect any updates from me unless something changes