Remove warnings when an addon can't be registered

Oheers / EvenMoreFish

An advanced fishing plugin based on MoreFish, created 2 years after its last update.

MIT License

91 stars 56 forks source link

Remove warnings when an addon can't be registered #260

Closed FireML closed 6 months ago

FireML commented 6 months ago

These warnings could not be removed, and there isn't really a point in having them.

This also removes the custom exceptions since they're no longer used.

sarhatabaot commented 6 months ago

Too bad you didn't wait for my response on this. I already made changes that made this only show up while in debug mode. There is a point in having these errors, if a user is has installed a custom addon, and didn't install the required dependency, an error should show up instead of a crash or other problem. Same with the RequiredJavaVersion error, since that may happen with some version specific addons. Please revert this change.

FireML commented 6 months ago

Debug mode does sound better than just removing them. That's ready to merge whenever