search

Oheers / EvenMoreFish

An advanced fishing plugin based on MoreFish, created 2 years after its last update.
MIT License
91 stars 56 forks source link

Add a boolean to saveUserData to specify whether it should use the scheduler #270

Closed FireML closed 5 months ago

FireML commented 5 months ago

Fixes a shutdown error by not using the scheduler when the plugin is being disabled

FireML commented 5 months ago

For a bit more context:

[20:20:18 ERROR]: Error occurred (in the plugin loader) while disabling EvenMoreFish v1.6.11.17 (Is it up to date?)
org.bukkit.plugin.IllegalPluginAccessException: Plugin attempted to register task while disabled
        at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler.runDelayed(FoliaGlobalRegionScheduler.java:65) ~[paper-1.20.2.jar:?]
        at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler.run(FoliaGlobalRegionScheduler.java:53) ~[paper-1.20.2.jar:?]
        at com.github.Anon8281.universalScheduler.foliaScheduler.FoliaScheduler.runTask(FoliaScheduler.java:49) ~[even-more-fish-1.6.11.17.jar:?]
        at com.oheers.fish.EvenMoreFish.saveUserData(EvenMoreFish.java:392) ~[even-more-fish-1.6.11.17.jar:?]
        at com.oheers.fish.EvenMoreFish.onDisable(EvenMoreFish.java:247) ~[even-more-fish-1.6.11.17.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:283) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugin(PaperPluginInstanceManager.java:225) ~[paper-1.20.2.jar:git-Paper-318]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugins(PaperPluginInstanceManager.java:149) ~[paper-1.20.2.jar:git-Paper-318]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.disablePlugins(PaperPluginManagerImpl.java:92) ~[paper-1.20.2.jar:git-Paper-318]
        at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:528) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_20_R2.CraftServer.disablePlugins(CraftServer.java:577) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:930) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:820) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1195) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.20.2.jar:git-Paper-318]
        at java.lang.Thread.run(Thread.java:840) ~[?:?]

Provided by nours on Discord