PlayerPoints Integration

Oheers / EvenMoreFish

An advanced fishing plugin based on MoreFish, created 2 years after its last update.

MIT License

91 stars 56 forks source link

PlayerPoints Integration #273

Closed FireML closed 5 months ago

FireML commented 5 months ago

Suggested in #271

Due to the way PlayerPoints works, we can only give it ints. Everything I've done here should account for that.

Adds the Economy class and an EconomyType enum so we can use the correct provider.
Adds a method to the Economy class which will format values so players don't get the wrong information.

To be specific, this will floor any doubles when PlayerPoints is used and return 0.0 when there is no Economy provider.
Fixes the ConfigUpdater because it wasn't working properly.
Adds better logging to the ConfigUpdater so admins know exactly what's going on.

This was designed in a way that should make adding other economy types quite easy, so i might add more if i feel like it / see requests for it.

FireML commented 5 months ago

Adds PlayerPoints as a potential reward type:
```
  catch-event:
    - "PLAYER_POINTS:100"
```

noaskers commented 5 months ago

If possible would be cool to add support for this one aswell: https://www.spigotmc.org/resources/coinsengine-economy-and-virtual-currencies.84121/

And it would also be cool if we can give these after selling fish at the shop ;)

FireML commented 5 months ago

If possible would be cool to add support for this one aswell: https://www.spigotmc.org/resources/coinsengine-economy-and-virtual-currencies.84121/

And it would also be cool if we can give these after selling fish at the shop ;)

Unfortunately that plugin doesn't have a repository for its API, so i won't be able to add it right now. I'd recommend asking the dev if there will be a maven repository at some point so this can be done.

noaskers commented 4 months ago

If I may add to this:

Add config option to choose economy plugin

It would be nice to have both options possible lets say u can choose both as shown here: https://github.com/Oheers/EvenMoreFish/issues/271