FireML
commented
2 months ago My suggestions:
- Split the Leaderboard class between each competition type
- Move the applyToLeaderboard method to the Leaderboard class
- Move the sendPlayerLeaderboard method to the Leaderboard class (and sendConsoleLeaderboard, but these should probably be merged for cleanliness)
- Add a getChatMessage to the Leaderboard class, which is used by the sendPlayerLeaderboard and can be used elsewhere if needed
These are all for the leaderboard, but will help the Competition classes look better.
Suggestion
We should refactor the Competition class file. It does too many things at once. Each competition type should be implemented in a different class file. I don't really have time to implement this so leaving this issue open so we don't forget.