search

OhhLoz / Harvester

A QoL FoundryVTT module to improve the harvesting and looting experience.
GNU General Public License v3.0
2 stars 2 forks source link

Compatibility with Ready Set Roll for D&D 5e #22

Closed 59thCaboose closed 5 months ago

59thCaboose commented 11 months ago

Hey, I was wondering if it was possible to have compatability with the module Ready Set Roll's Quick Roll feature? The module allows for dice rolls to be done automatically when activating an item, feature, skill, etc, however when this option is enabled, Harvester seems to be unable to register the related harvest roll.

The first image is what is shown when Quick Roll for Items is enabled, which has no dice result, or option to roll a skill check. Harvest 1

The second image shows with the feature turned off, and the module works as normal. Harvest 2

I don't know if this is technically a Harvester or Ready Set Roll issue, but it would be good fun to get these modules working together for my games. For general info this has been tested on the latest Foundry Version 11 (11.313), with both modules up to date. The console shows no errors, or even anything out of the ordinary.

Obviously this isn't a major issue at all, but anything is appreciated, thank you!

OhhLoz commented 10 months ago

Hmm, the Ready Set Rolls code seems rather complex compared to mine. Im assuming it can roll things in Formula / Other Formula which is what Harvester uses. Harvester renames the Other Formula button to the relevant skill check by editing the HTML directly which might be what is messing with Ready Set Roll as it may be looking for "Other Formula" and getting "Nature Skill Check" instead

p4535992 commented 5 months ago

It should be already solved with the requestor integration.