D&D 3.0.x compatibility.

OhhLoz / Harvester

A QoL FoundryVTT module to improve the harvesting and looting experience.

GNU General Public License v3.0

2 stars 2 forks source link

D&D 3.0.x compatibility. #34

Closed ctbritt closed 6 months ago

ctbritt commented 6 months ago

Would request this be updated for dn5e 3.0.x... so far, it runs, without errors, but the button to make a skill check doesn't show up, possibly because of the new D&D chat cards.

ctbritt commented 6 months ago

Apologies... looks like there might be a MidiQOL interaction as well. It's looking to replace <div class="chat-buttons"> but that doesn't exist with midi enabled. What gets generated is <div class="chat-buttons midi-buttons">

Here's a screenshot of the section of code in question CleanShot 2024-02-22 at 12 26 35

not quite sure how to fix this, as Midi under 3.0 makes some serious changes to the chat card.

Mind you, it doesn't show the button even when Harvester is the only module enabled, either, so ...

OhhLoz commented 6 months ago

Yeah thanks for letting me/us know, as p4535992 mentioned merging the pull request will likely fix the button issue as the current method is rather hacky. Afaik midiqol currently doesnt work with dnd3.0

ctbritt commented 6 months ago

Turns out it's not midi -- i'm running the 11.4.x beta. The button vanishes when only Harvester, libwrapper and socketlib are enabled.

OhhLoz commented 6 months ago

Fixed as of 1.7.2