OhhLoz / Harvester

A QoL FoundryVTT module to improve the harvesting and looting experience.
GNU General Public License v3.0
2 stars 2 forks source link

Cant loot consumables when harvesting a creature #35

Closed Asiermd closed 5 months ago

Asiermd commented 6 months ago

Module Version: v1.7.2

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Create a custom table with items as consumables
  2. Try to harvest those consumables
  3. See error

Expected behavior For the consumables to be looted as normal

Screenshots

image

Browser: Google Chrome Versión 122.0.6261.70 (Build oficial) (64 bits)

Foundry Version:

Version 11 Build 315

Game System:

DnD 5e

p4535992 commented 6 months ago

Ty for ticket we will solve the warning . Did you have other modules active like Item Piles or BRT ?

Asiermd commented 6 months ago

I have (probably too) many, including those 2, i will share screenshots of the one im using right now. image image image image

OhhLoz commented 6 months ago

Should be fixed in 1.7.3

Asiermd commented 6 months ago

Im sorry, but i dont see it fixed, i try to loot consumables and i cant, im in the 2.4.1 DnD version, havent upgraded it to 3.x.x yet, that may be the problem?

OhhLoz commented 6 months ago

Im sorry, but i dont see it fixed, i try to loot consumables and i cant, im in the 2.4.1 DnD version, havent upgraded it to 3.x.x yet, that may be the problem?

It's possible, 1.7.2 onwards have been made with 3.0.0 in mind. I haven't tested back compatibility. I didn't make the bugfix so I can't say with much certainty.

p4535992 commented 6 months ago

it should work on 2.4.1. You still say "Loot consumables", did you mean "Harvesting cosumable" ? The loot operation let you only retrieve currency no ?

Asiermd commented 6 months ago

I meant harvesting yes, i think im doing everything alright cause i can harvest items categorized as "loot" but not the ones that are "consumables", there is no error in the console either when i try with the minimum modules possible, (harvester, better roll tables and dependencies) so i dont know why can it be.

p4535992 commented 6 months ago

Can you enable the "debug" settings of the module and see what the logs tell you ?

Asiermd commented 6 months ago

image

p4535992 commented 6 months ago

I add a bunch of logs on 1.7.4, try again with the new logs, but from the screenshot i can see the source reference is wrong.

Like i said in the README

In the BRT Harvest Rolltable sheet, the "Source Reference" field is the one used by this module to connect the monster to the rolltable! So "Source Reference" === "Name of The Monster" so for example if the monster name is "Ice Wolf" you must put on the source reference "Ice Wolf"

But i notice now there is a limitation on the items with only the "loot" type for unknwon reasons ? i'll try to remove that in a next release.

Asiermd commented 6 months ago

image image I used "Harvest" cause its my testing world, so most things have obvious names to why they were created, like the name for the harvesting to be "loot" and "consumable", in this case, the actor being named "harvest"

p4535992 commented 6 months ago

From the logs everything seem fine , in this case is working right ? we need just to remove the filter for the "loot" type ?

Asiermd commented 6 months ago

It seems like the filter for the item type being the problem, yes, as i can harvest another item in the loot category just fine even when it is a higher skill check.

Asiermd commented 5 months ago

Im sorry to be annoying, but i wanna know if this will be worked on, if not, i will edit the consumable items that i have.

p4535992 commented 5 months ago

i'll try to find some time tomorrow

Asiermd commented 5 months ago

Thanks a lot.

p4535992 commented 5 months ago

Try out 1.7.9

Asiermd commented 5 months ago

IT WORKS! Thank you, and sorry for the troubles