[BUG] Every corpse coming up empty regardless of skill roll

[ctbritt]

Module Version: v1.7.3

Before open any issue

1) Enable the module setting "Enable debugging" 2) Click F12 go to the console tab 3) make the test you want and replicate the error 4) Go to the tab console open on point 2) and just right click and click 'Save as' and 'Save' or send a screenshot of the exception on the console. 5) Attach the text file on the github issue with all the logs related tot he module, or send a screenshot of the messages on the console.

No errors show up with debug on.

Describe the bug no matter what I roll on the skill check, it says "After examing the corpse, you realize there is nothing you can harvest" To Reproduce

Steps to reproduce the behavior:

1. target a dead token
2. Click on Harvest
3. Roll skill check prompted by Requestor
4. See error

Expected behavior That items would be generated from the Better Roll Table of harvest items, added to the ItemPiles of the dead creature and be able to be harvested

Screenshots

Browser:

• Chromium Engine Version 122.0.6261.94

Foundry Version:

• v11.315

Game System:

• D&D5e 3.0.3

Additional context Have tried with both BRT and without BRT. Same result. Have also tried with only Harvester and Requestor enabled. Same result.

[p4535992]

Add on version 1.7.4 a bunch of logs can you tell me what did you see on the web console with the prefix harvester | Remember you must enable the debug options of the module.

[ctbritt]

ok. here's some new data. Only modules active are: libwrapper socketlib Harvester Better Tables Requestor ItemPiles

This is the error I'm getting when I click harvest on a dragon corpse:

[ctbritt]

OK. Here's where we're at. My settings are as follows:

With these settings, when I try to harvest a creature, no matter what I roll, it says nothing can be harvested.

This is the debug setting I got:

[p4535992]

ok. here's some new data. Only modules active are: libwrapper socketlib Harvester Better Tables Requestor ItemPiles

This is the error I'm getting when I click harvest on a dragon corpse:

Totally missed that. Fixed on 1.7.6

[ctbritt]

if I turn ON Automatically Assign Items this is the result: and console output is this:

The item is added to his inventory automatically, when it should be added to the item pile.

[ctbritt]

also, is it normal to have both a pop up and a chat card prompt?

[ctbritt]

sorry to be a bother. Now this error with 1.7.6:

[p4535992]

I think this is a new feature "The item is added to his inventory automatically, when it should be added to the item pile.", becuase i think you want:

1) Harvest the target 2) Automatically convert the targeted token to a item piles (with the option to remove all the already present items problaby...) 3) Let the players checkout the corpe as a standard item piles

I purposely avoided the second step because without clever filters on targeting, people would destroy their characters because they were wrongly targeting

[p4535992]

sorry to be a bother. Now this error with 1.7.6:

Fix again on 1.7.7 .... sorry

[p4535992]

also, is it normal to have both a pop up and a chat card prompt?

Is a requestor settings i can probably add a module setting for have only the chat button by default

[p4535992]

also, is it normal to have both a pop up and a chat card prompt?

add a module setting for this on 1.7.8 (by default is false)

[ctbritt]

I think this is a new feature "The item is added to his inventory automatically, when it should be added to the item pile.", becuase i think you want:

1. Harvest the target
2. Automatically convert the targeted token to a item piles (with the option to remove all the already present items problaby...)
3. Let the players checkout the corpe as a standard item piles

I purposely avoided the second step because without clever filters on targeting, people would destroy their characters because they were wrongly targeting

I think this could skip the conversion to itempiles step. Monk's Token Bar already converts dead tokens to itempiles when combat ends, so maybe you just add a check? That's what I did in my initial PR that added itempiles to the module.

1. Check the corpse
2. Itempiles? Skip to step 4
3. No itempiles? Convert to itempiles
4. Harvest

[OhhLoz]

Should be fixed in 1.8.0 release