Closed p4535992 closed 5 months ago
Hi Thanks once again for your work, its greatly appreciated.
Apologies for the late response i've been away for the week, I did some testing and ran into an issue where the harvested effect wasnt being added and presumably subsequently stopping the item piles being generated.
I notice that the harvest action no longer has an attached harvested effect which is how I was handling it when I was still actively developing the project, has it changed since then?
Finally, I'm a little hesistant to add more dependencies / requirements, adding requestor made sense as it improved the core functionality, it would be preferable to add support instead of dependencies for users who don't want to use Item Piles / BRT.
Apologies for the late response i've been away for the week, I did some testing and ran into an issue where the harvested effect wasnt being added and presumably subsequently stopping the item piles being generated.
I'll check out
I notice that the harvest action no longer has an attached harvested effect which is how I was handling it when I was still actively developing the project, has it changed since then?
I'll check out
Finally, I'm a little hesistant to add more dependencies / requirements, adding requestor made sense as it improved the core functionality, it would be preferable to add support instead of dependencies for users who don't want to use Item Piles / BRT.
This can be a problem because many things (multiple checks ecc.) are done with BRT and sadly item-piles is a dependency for that module, let me think about it.
@OhhLoz Release 1.8.1 ready to test.
Apologies for the late response i've been away for the week, I did some testing and ran into an issue where the harvested effect wasnt being added and presumably subsequently stopping the item piles being generated.
Should be fixed.
I notice that the harvest action no longer has an attached harvested effect which is how I was handling it when I was still actively developing the project, has it changed since then?
No you don't need that anymore, or at least I don't see any use of it because of the way the module is set up at least now, but I don't think it was used before either.
Finally, I'm a little hesistant to add more dependencies / requirements, adding requestor made sense as it improved the core functionality, it would be preferable to add support instead of dependencies for users who don't want to use Item Piles / BRT.
Item Piles and BRT are now OPTIONAL modules.... :(, you will have a very basic use of the module . For solve this annoyng issue i created a compendium with the rolltables for the harvest action.
Let me know it, if you find something else, here the code to test harvester_1.8.1.zip
Thanks once again for your work, I tested and it works perfectly, I'll publish it as 1.8.0 instead of 1.8.1
Hi @OhhLoz made this big upgrade of the project, really need some beta tester about it.
Start some better documentation on the README.md
For anyone want to test out te beta i put a zip here: harvester_1.8.0.zip