Item piles massive integration

[p4535992]

Hi @OhhLoz made this big upgrade of the project, really need some beta tester about it.

• Rewrite a bunch of code... hopefully for the last time
• Add module "Item Piles " as mandatory, the module already has a lot of features and functionality that doesn't make sense to rewrite, plus now you can manage custom currencies too (note for the future with a little more effort we can make this module multisystem XD)
• Add "Better Rolltables" as mandatory , the dnd5e 3.X.X force my hand here..., but the module already has a lot of features and functionality that doesn't make sense to rewrite
• Add a new "Share It" and "Keep it" options for the harvester action this should be the solution for https://github.com/OhhLoz/Harvester/issues/37, now each player can decide whether to keep the harvesting result lost (Keep it !) , or make it available to others with Item Piles (Share it !)
• Add BRT support for the loot action too (code more readable i hope...)
• Solved https://github.com/OhhLoz/Harvester/issues/31 this feature was included in BRT recently "Use Dynamic DC" (For anyone interested, this feature was included in BRT recently "Use Dynamic DC")
• Also solved https://github.com/OhhLoz/Harvester/issues/23, this feature was included in BRT recently "Inline currency data roll on table text result" (his feature was included in BRT recently),you must set a Loot Table for apply a currency
• Add a regex check on the source reference check for solve the request https://github.com/OhhLoz/Harvester/issues/27

Start some better documentation on the README.md

For anyone want to test out te beta i put a zip here: harvester_1.8.0.zip

[OhhLoz]

Hi Thanks once again for your work, its greatly appreciated.

Apologies for the late response i've been away for the week, I did some testing and ran into an issue where the harvested effect wasnt being added and presumably subsequently stopping the item piles being generated.

I notice that the harvest action no longer has an attached harvested effect which is how I was handling it when I was still actively developing the project, has it changed since then?

Finally, I'm a little hesistant to add more dependencies / requirements, adding requestor made sense as it improved the core functionality, it would be preferable to add support instead of dependencies for users who don't want to use Item Piles / BRT.

[p4535992]

Apologies for the late response i've been away for the week, I did some testing and ran into an issue where the harvested effect wasnt being added and presumably subsequently stopping the item piles being generated.

I'll check out

I notice that the harvest action no longer has an attached harvested effect which is how I was handling it when I was still actively developing the project, has it changed since then?

I'll check out

Finally, I'm a little hesistant to add more dependencies / requirements, adding requestor made sense as it improved the core functionality, it would be preferable to add support instead of dependencies for users who don't want to use Item Piles / BRT.

This can be a problem because many things (multiple checks ecc.) are done with BRT and sadly item-piles is a dependency for that module, let me think about it.

[p4535992]

@OhhLoz Release 1.8.1 ready to test.

Apologies for the late response i've been away for the week, I did some testing and ran into an issue where the harvested effect wasnt being added and presumably subsequently stopping the item piles being generated.

Should be fixed.

I notice that the harvest action no longer has an attached harvested effect which is how I was handling it when I was still actively developing the project, has it changed since then?

No you don't need that anymore, or at least I don't see any use of it because of the way the module is set up at least now, but I don't think it was used before either.

Finally, I'm a little hesistant to add more dependencies / requirements, adding requestor made sense as it improved the core functionality, it would be preferable to add support instead of dependencies for users who don't want to use Item Piles / BRT.

Item Piles and BRT are now OPTIONAL modules.... :(, you will have a very basic use of the module . For solve this annoyng issue i created a compendium with the rolltables for the harvest action.

Let me know it, if you find something else, here the code to test harvester_1.8.1.zip

[OhhLoz]

Thanks once again for your work, I tested and it works perfectly, I'll publish it as 1.8.0 instead of 1.8.1