search

Ohjeah / sparsereg

a collection of modern sparse (regularized) linear regression algorithms.
MIT License
61 stars 21 forks source link

sindy model features #13

Closed TarenGorman closed 6 years ago

Ohjeah commented 6 years ago

Can you vectorize the main for-loop in _derivative?

TarenGorman commented 6 years ago

Do you think it best to leave it as two params, dt and timestamps?

Or.. should it just be the dt param.. and if dt is given as a list/np.array _derivative follows the timestamps logic?

Ohjeah commented 6 years ago

You could write a check to make sure that it is either dt or timestamps. Or just default to timestamps if they are provided.

Ohjeah commented 6 years ago

Your test fails. Could you please check that?

TarenGorman commented 6 years ago

Should be passing now, syntax issue.

Ohjeah commented 6 years ago

Sweet.