search

Ohmbrewer / ohmbrewer

The web application for a happy brew day.
http://ohmbrewer.github.io
0 stars 0 forks source link

added rubocop gem for static analysis #103

Closed kathomas921 closed 8 years ago

kathomas921 commented 8 years ago

Added the gem and the config file, where we can more easily tune what we want changed.

kyleoliveira commented 8 years ago

You should also add a Rake task for this. You can do so by creating a file called lib/tasks/rubocop.rb and filling it with:

require 'rubocop/rake_task'

RuboCop::RakeTask.new

See https://github.com/bbatsov/rubocop#rake-integration for more details. This will make it really easy to integrate calling RuboCop into most IDEs.

kyleoliveira commented 8 years ago

Done reviewing for now. Let me know when you're ready for me to take another look at it.

kyleoliveira commented 8 years ago

I think this is good to go pending a squash.

kathomas921 commented 8 years ago

closed for #105