kyleoliveira
commented
8 years ago Since you don't need to make any actual changes to them, could you copy the following files from the master branch (or otherwise take them out of the commit):
- [ ] db/schema.rb
- [ ] app/views/recipes/index.html.erb
- [ ] app/assets/javascripts/application.js
- [ ] Gemfile.lock
You can do that by just copying the files' content from the raw page on GitHub, pasting it into the respective files, and adding another commit with the update.
KT: I made an actual change to application.js to remove turbolinks. I can come back to that eventually if/when I try again at moving js to the pipeline, but for now, turbolinks will load the page before the js is finished so the graph won't appear until the user refreshes the page. So, for now, I took turbolinks out.
kathomas921
Ok, so as you'll see its very basic at the moment. I used straight js in the view because I wasn't sure where to put it - I haven't really done the front end of rails before. I imagine this should be changed. Also, most of the equipment label (heating element, pump, etc) column is cut off. I have no idea where to search to reset that. I tried to just put it in a div and set the height and width values, but that didn't work. I have also yet to figure out how to appropriately adjust the x-axis so that it shows minutes. Right now the hours are based off of the multiplication in the timeline method in schedule.rb. When I had it in minutes, the x axis was 0, 30, 0, 30 rather than 0, 30, 60, 90. Minutes seem like a better option, but hours was less confusing for the moment.
Anyway, there are obviously a lot of issues, but since I just started out, I'd appreciate a code review/suggestions/additions from anyone.
@Ohmbrewer/web-team