search

Ohmbrewer / ohmbrewer

The web application for a happy brew day.
http://ohmbrewer.github.io
0 stars 0 forks source link

Schedule #92

Closed kathomas921 closed 8 years ago

kathomas921 commented 8 years ago

This isn't ready to go yet, but I made some changes to creation/modification of schedules.

You now need to enter exactly one task (root task) when you create a schedule. All non-root tasks need a trigger and parent. "Save" saves all new tasks and reloads the edit page rather than taking you back to the index (which "Back" does now). The root task is automatically assigned upon schedule creation. You can't delete or change the root task (at the moment, there are too many things that can go wrong if you have the ability to change or delete the root task).

Issues: I am a CSS muggle and have no idea why the "Save" button is the whole width of the page, nor have any idea where to look to fix it. I cannot figure out how to only allow a user to enter a single task before creating the schedule (ex. having the green button disappear after pressing it once if you haven't created the schedule yet, or eliminating the button for "new" and having a single set of fields show up automatically).

I think that's it for now. Let me know if you have any suggestions for the issues mentioned.

kyleoliveira commented 8 years ago

With respect to button sizes, check out the CSS classes provided by Bootstrap - that's generally how we're handling that stuff.

kathomas921 commented 8 years ago

I changed back the functionality so 'save' returns to the index. I made some extra validations to ensure that non root tasks require both parent_id and trigger and that root tasks have neither.

@kyleoliveira Let me know if there is anything you still want changed or implemented before I merge in with master.

kyleoliveira commented 8 years ago

@kathomas921 Updated comments. Let me know if you've got questions and/or grab me on Hangouts if you need more help.

kyleoliveira commented 8 years ago

If you revert the changes to the files that are only changing indentation or line endings, and squash this into a single commit, I think this will be ready to go. I haven't tested it out yet, but I'll take your word on it.